Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unnecessary copy when calling to_cpu on cpu data #179

Open
Shayan-P opened this issue Aug 27, 2023 · 0 comments
Open

unnecessary copy when calling to_cpu on cpu data #179

Shayan-P opened this issue Aug 27, 2023 · 0 comments
Labels
good first issue Good for newcomers GPU related to new gpu support addition

Comments

@Shayan-P
Copy link
Collaborator

The functions to_cpu, to_gpu copy the data regardless of where it resides.

It would be more intelligent to copy only if the data is not on the same device (calling to_cpu when data is on GPU and vice versa)

@Shayan-P Shayan-P added good first issue Good for newcomers GPU related to new gpu support addition labels Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers GPU related to new gpu support addition
Projects
None yet
Development

No branches or pull requests

1 participant