Changes necessary to compile under JS strict mode #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstray
commented
Aug 1, 2017
| @@ -11,7 +11,7 @@ var _session = { | |||
| emSize: 10, | |||
| width: 640, | |||
| timerOn: (localStorage.hasOwnProperty("model") === true), | |||
| nowOffset: getTZOffset(now), | |||
| nowOffset: now.getTimezoneOffset(), | |||
There was a problem hiding this comment.
Actually this line I am not sure about. I couldn't find getTZOffset() anywhere in the code base -- is this an equivalent replacement? Perhaps not, because I don't think the "your current time zone" format looks right. After this change it's in minutes, rather than a string like "-07:00"
There was a problem hiding this comment.
Ok after further research I am sure this is wrong. Is there any way to exclude a single file from a commit... or should I just add a new commit which fixes, and then add it to the PR?
|
These var declarations look good. I made similar changes in a working branch that converts the code to es2015 spec. |
|
Resubmitting a new PR with the timezone thing reverted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cannot declare variables without var.