Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed wrong suffix check #710

Merged
merged 2 commits into from
Aug 25, 2022
Merged

fixed wrong suffix check #710

merged 2 commits into from
Aug 25, 2022

Conversation

hadugen
Copy link
Contributor

@hadugen hadugen commented Aug 25, 2022

for libs like bson-1.0.dll, mongoc-1.0.dll competeSuffix returns 0.dll, thats a bug, and not supposed be like that

Copy link
Member

@EndrII EndrII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for help.

@EndrII EndrII enabled auto-merge August 25, 2022 07:24
@EndrII EndrII self-assigned this Aug 25, 2022
@EndrII EndrII added Bug Something isn't working Windows Windows version labels Aug 25, 2022
@EndrII EndrII added this to the v1.5 milestone Aug 25, 2022
Copy link
Member

@EndrII EndrII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests was failed

Deploy/dependenciesscanner.cpp Outdated Show resolved Hide resolved
auto-merge was automatically disabled August 25, 2022 07:32

Head branch was pushed to by a user without write access

Co-authored-by: Andrei Yankovich <EndrIIMail@gmail.com>
@EndrII EndrII enabled auto-merge August 25, 2022 07:33
@EndrII EndrII merged commit 7c08b6d into QuasarApp:main Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Windows Windows version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants