Async keys auth #54
Merged
Async keys auth #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IgorekLoschinin
approved these changes
Feb 14, 2022
Comment on lines
+209
to
+236
| auto free = [eckey, ecgroup] () { | ||
| if (*ecgroup) | ||
| EC_GROUP_free(*ecgroup); | ||
|
|
||
| if (*eckey) | ||
| EC_KEY_free(*eckey); | ||
| }; | ||
|
|
||
| *eckey = EC_KEY_new(); | ||
| if (!*eckey) { | ||
| printlastOpenSSlError(); | ||
| free(); | ||
| return false; | ||
| } | ||
|
|
||
| *ecgroup = EC_GROUP_new_by_curve_name(NID_secp256k1); | ||
|
|
||
| if (!*ecgroup) { | ||
| printlastOpenSSlError(); | ||
| free(); | ||
| return false; | ||
| } | ||
|
|
||
| if (!EC_KEY_set_group(*eckey, *ecgroup)) { | ||
| printlastOpenSSlError(); | ||
| free(); | ||
| return false; | ||
| } |
There was a problem hiding this comment.
It's a little unclear what's going on here.
| QVERIFY(QH::AuthECDSA::makeKeys(pub, priv)); | ||
|
|
||
| // check createed keys. should be larget then 0. | ||
| QVERIFY(pub.length() && priv.length()); |
There was a problem hiding this comment.
Is this test redundant by any chance?
| // create test auth object using ecdsa algorithm | ||
| ECDSA edsa(pub, priv); | ||
|
|
||
| // The terst object should be invalid because it is not prepared. |
There was a problem hiding this comment.
Suggested change
| // The terst object should be invalid because it is not prepared. | |
| // The test object should be invalid because it is not prepared. |
| data.insert(0, reinterpret_cast<const char*>(&_unixTime), | ||
| sizeof(_unixTime)); | ||
|
|
||
| return checkSign(data, _signature, _publicKey); |
There was a problem hiding this comment.
Where does this method come from, I don’t see either from which it is connected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support of ecdsa encryption for async authentication interface.