Enhancement for the Integrate() function #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and the number of quadrature points needed and scheme implemented in the code. The wave blows up after some time. It is faster than the previous implementation.
…ntegral using quadrature method.
… integral for a special case of N_LGL = N_quad for lobatto quadrature
Balavarun5
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous PR #16 , To compute the integrals in the code an Integrate() function which takes in the analytical form of the function to compute the integral using quadrature method was implemented.
Integrations in the code were not vectorized and hence the code was slow(1.1 iterations/second on Inspiron-3542).
This PR uses an Integrate function which takes in the coefficients of the integrands and returns the integral. This implementation is vectorized and is faster (40 iterations/second).
The 1D wave equation bug #6 is still present, however it's nature hasn't been confirmed.