Update to anaconda-29.24.7 #1
Conversation
There was a problem hiding this comment.
Looking at the amount of patching for qubes installclass, it may be easier to keep it as a separate source file (Source1: qubes.py), since it isn't part of the upstream sources anyway. This way, adjusting it will be just about making a commit, not a patch+commit.
AFAIU, more and more things will be possible by just editing installclass, instead of internal anaconda files.
0001-add-Qubes-installclass.patch
Outdated
| + storage) | ||
| + for autoreq in list(storage.autopart_requests): | ||
| + BaseInstallClass.setDefaultPartitioning(self, storage) | ||
| + for autoreq in storage.autopart_requests: |
There was a problem hiding this comment.
Removing list() here looks like a bug. See QubesOS/qubes-installer-qubes-os@a7f17ac#diff-7e3332c5fd0270d97c964e52ba184ad8
| + missing_features.append('Interrupt Remapping') | ||
| + status = ', '.join(missing_features) | ||
| + | ||
| + warnings.append(WARNING_HARDWARE_UNSUPPORTED % {'features': status}) |
There was a problem hiding this comment.
I think this will show the warning unconditionally, even if no feature is missing. The previous patch had if status: here.
| + self.password_entry.grab_focus() | ||
| -- | ||
| 2.17.2 | ||
|
|
There was a problem hiding this comment.
Was this patch removed intentionally? It touches not only qubes.py
No description provided.