device identity #39
device identity #39
Conversation
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024111601-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024091704-4.3&flavor=update
Failed tests13 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/112766#dependencies 199 fixed
Unstable tests
|
|
from openQA: |
|
The above error is still the case in the most recent run |
|
|
qubesusbproxy/tests.py
Outdated
| qubesusbproxy.core3ext.USBDevice(back, "1-1") | ||
| ) | ||
|
|
||
| self.ext.attach_and_notify = Mock() |
There was a problem hiding this comment.
extension object actually is a singleton
Ok, that explains a lot
There was a problem hiding this comment.
I haven't tried manually fixing this, but if I skip this test class, the other one passes in full, no more "Device connection failed" errors etc :)
There was a problem hiding this comment.
If it's applicable to all tests, maybe it's cleaner to apply patch in setUp() (and unpatch in tearDown())? That means calling start() and stop() on the patch object instead of using as a context manager.
But, I see the first test doesn't patch this, so I'm not sure if that's really applicable...
|
This also fails horribly on R4.2 (utils.py tries to import device_protocol, then uses |
|
Ok, the last test run on R4.3 shows no regressions. I'll split the branch for R4.2 and then (finally) merge this all. |
implements QubesOS/qubes-issues/issues/9325