Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide local timezone from VMs with specific tag #632

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

strategictraveler
Copy link

Set fake timezone for VMs with the "anon-timezone" tag. Fixes QubesOS/qubes-issues#8381

Set fake timezone for VMs with the "anon-timezone" tag.
Fixes QubesOS/qubes-issues#8381
Copy link

codecov bot commented Nov 2, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.31%. Comparing base (6935f26) to head (a5dd3ba).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
qubes/vm/qubesvm.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #632      +/-   ##
==========================================
- Coverage   69.31%   69.31%   -0.01%     
==========================================
  Files          58       58              
  Lines       11994    11996       +2     
==========================================
+ Hits         8314     8315       +1     
- Misses       3680     3681       +1     
Flag Coverage Δ
unittests 69.31% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marmarek
Copy link
Member

marmarek commented Nov 3, 2024

Looks good but please add a test for this, see https://github.com/QubesOS/qubes-core-admin/blob/main/qubes/tests/vm/qubesvm.py, especially look at some with "qdb" in name.

@strategictraveler
Copy link
Author

I'll look at it this weekend.

@strategictraveler strategictraveler marked this pull request as draft November 4, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop leaking dom0 timezone to Qubes-Whonix
2 participants