Add os-release ID_LIKE to features #504
Conversation
| distro_like=$(awk -F '=' '/^ID_LIKE=/{ print $2 }' /etc/os-release) | ||
| qvm-features-request os-distribution-like="${distro_like}" | ||
|
|
||
| version=$(awk -F '[="]' '/^VERSION_ID=/{ print $3 }' /etc/os-release) |
There was a problem hiding this comment.
This needs a bit more care - VERSION_ID value sometimes it quoted but sometimes not
There was a problem hiding this comment.
Last commits deals with this now.
| version=${version#\"} | ||
| version=${version%\"} | ||
| distro_like=$(awk -F '=' '/^ID_LIKE=/{ print $2 }' /etc/os-release) | ||
| qvm-features-request os-distribution-like="${distro_like}" |
There was a problem hiding this comment.
This needs also the backend side, see QubesOS/qubes-core-admin#578 and later QubesOS/qubes-core-admin#585.
What is the "extensive list of supported distributions of Debian" what you can find on Qubes?
There was a problem hiding this comment.
This needs also the backend side, see QubesOS/qubes-core-admin#578 and later QubesOS/qubes-core-admin#585.
Will take care of this soon.
What is the "extensive list of supported distributions of Debian" what you can find on Qubes?
That I can find on Qubes by default is only kali and whonix. That someone can install from a 3rd party template, that is higher.
ben-grande
force-pushed
the
report-id-like
branch
from
3fb72ad to
a99da61
Compare
|
I didn't think grep, awk, sed, cut, head where a good use of resources. Got some code from |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #504 +/- ##
=======================================
Coverage 70.57% 70.57%
=======================================
Files 3 3
Lines 469 469
=======================================
Hits 331 331
Misses 138 138 ☔ View full report in Codecov by Sentry. |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024061011-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024052808-4.3&flavor=update
Failed tests22 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/101100#dependencies 37 fixed
Unstable tests |
ben-grande
force-pushed
the
report-id-like
branch
from
a99da61 to
0e92901
Compare
Very useful to apply configuration based on the base distribution that the OS was created upon, instead of adding an extensive list of supported distributions of Debian.
ben-grande
force-pushed
the
report-id-like
branch
from
0e92901 to
c33b577
Compare
For: QubesOS/qubes-core-agent-linux#504 (cherry picked from commit 0f3bef9)
Very useful to apply configuration based on the base distribution that the OS was created upon, instead of adding an extensive list of supported distributions of Debian.