Downgrade errors about incompatible service config to warnings #168
Conversation
If service type is changed from socket to executable, some config options are not applicable anymore. Do not fail execution but just log a warning. This is also relevant for migration in the other direction - if user has an executable service that is updated to a socket service, user may want preserve the executable variant (which is also done by the package manager if user has modified said service) - in which case, the config for socket variant should not prevent this configuration from working. This has been reported to happen with qubes.UpdatesProxy service. Fixes QubesOS/qubes-issues#9299
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #168 +/- ##
==========================================
- Coverage 77.93% 77.91% -0.03%
==========================================
Files 54 54
Lines 9618 9612 -6
==========================================
- Hits 7496 7489 -7
- Misses 2122 2123 +1 ☔ View full report in Codecov by Sentry. |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024061414-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024052808-4.3&flavor=update
Failed tests13 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/101100#dependencies 38 fixed
Unstable tests
|
If service type is changed from socket to executable, some config
options are not applicable anymore. Do not fail execution but just log a
warning. This is also relevant for migration in the other direction - if
user has an executable service that is updated to a socket service, user
may want preserve the executable variant (which is also done by the
package manager if user has modified said service) - in which case, the
config for socket variant should not prevent this configuration from
working.
This has been reported to happen with qubes.UpdatesProxy service.
Fixes QubesOS/qubes-issues#9299