small fix: actually sanitize service name

[piotrbartman]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.99%. Comparing base (9e09690) to head (45527be).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #172      +/-   ##
==========================================
- Coverage   78.08%   77.99%   -0.09%     
==========================================
  Files          54       54              
  Lines        9668     9668              
==========================================
- Hits         7549     7541       -8     
- Misses       2119     2127       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[qubesos-bot]

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024080713-4.3&flavor=pull-requests

Test run included the following:

• Accept only files for qvm-open-in-(d)vm qubes-core-agent-linux#513 (QubesOS/qubes-core-agent-linux@e17c186)
• Support using UUIDs instead of VM names qubes-core-admin#574 (QubesOS/qubes-core-admin@8039442)
• Fix plymouth on multi-screens with different resolution qubes-artwork#41 (QubesOS/qubes-artwork@2148dce)
• Use QubesDB for knowing if mic is allowed or not qubes-gui-daemon#145 (QubesOS/qubes-gui-daemon@c6acd17)
• setup-ip: Invoke 'ip' via $PATH  qubes-core-agent-linux#516 (QubesOS/qubes-core-agent-linux@08fe31f)
• tests/integ/audio.py: add test for audio-intput in QubesDB qubes-core-admin#608 (QubesOS/qubes-core-admin@226805d)
• Allow hexadecimal numbers qubes-gui-agent-linux#197 (QubesOS/qubes-gui-agent-linux@fc04d11)
• Implement UUID support in qrexec #135 (62ce536)
• tests: increase memory size for webcam viewing VM qubes-video-companion#28 (QubesOS/qubes-video-companion@97a6dde)
• small fix: actually sanitize service name #172 (45527be)
• Fix warped SVG icons, ensure correct rasterized size qubes-core-agent-linux#517 (QubesOS/qubes-core-agent-linux@d993b42)

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024070519-4.3&flavor=update

• system_tests_pvgrub_salt_storage

  • TC_41_HVMGrub_debian-12-xfce: test_000_standalone_vm (error)
    qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

  • TC_41_HVMGrub_debian-12-xfce: test_010_template_based_vm (error)
    qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

• system_tests_extra

  • TC_00_QVCTest_whonix-gateway-17: test_010_screenshare (failure)
    self.assertNotEqual(vm.run('test -e /dev/vid... AssertionError: 0 == 0

• system_tests_usbproxy

  • TC_20_USBProxy_core3_whonix-gateway-17: test_070_attach_not_installed_front (error)
    qubesusbproxy.core3ext.QubesUSBException: Device attach failed: 202...

• system_tests_network_updates

  • VmUpdates_debian-12-xfce: test_020_updates_available_notification (error)
    subprocess.CalledProcessError: Command '/usr/lib/qubes/upgrades-sta...

  • VmUpdates_debian-12-xfce: test_120_updates_available_notification_qubes_vm_update (error)
    subprocess.CalledProcessError: Command '/usr/lib/qubes/upgrades-sta...

Failed tests

9 failures

• system_tests_pvgrub_salt_storage

  • TC_41_HVMGrub_debian-12-xfce: test_000_standalone_vm (error)
    qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

  • TC_41_HVMGrub_debian-12-xfce: test_010_template_based_vm (error)
    qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

  • [unstable] TC_41_HVMGrub_fedora-40-xfce: test_000_standalone_vm (error)
    qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

  • TC_41_HVMGrub_fedora-40-xfce: test_010_template_based_vm (error)
    qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

• system_tests_extra

  • [unstable] TC_00_QVCTest_debian-12-xfce: test_020_webcam (failure)
    self.assertEqual(len(img1), len(... AssertionError: 12441600 != 460800

  • TC_00_QVCTest_whonix-gateway-17: test_010_screenshare (failure)
    self.assertNotEqual(vm.run('test -e /dev/vid... AssertionError: 0 == 0

• system_tests_usbproxy

  • TC_20_USBProxy_core3_whonix-gateway-17: test_070_attach_not_installed_front (error)
    qubesusbproxy.core3ext.QubesUSBException: Device attach failed: 202...

• system_tests_network_updates

  • VmUpdates_debian-12-xfce: test_020_updates_available_notification (error)
    subprocess.CalledProcessError: Command '/usr/lib/qubes/upgrades-sta...

  • VmUpdates_debian-12-xfce: test_120_updates_available_notification_qubes_vm_update (error)
    subprocess.CalledProcessError: Command '/usr/lib/qubes/upgrades-sta...

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/105374#dependencies

7 fixed

• system_tests_splitgpg

  • TC_10_Thunderbird_debian-12-xfce: test_010_send_receive_inline_signed_only (failure)
    dogtail.tree.SearchError: descendent of [application | Thunderbird]...

  • TC_10_Thunderbird_whonix-workstation-17: test_020_send_receive_inline_with_attachment (failure)
    dogtail.tree.SearchError: descendent of [application | Thunderbird]...

• system_tests_extra

  • TC_00_QVCTest_fedora-40-xfce: test_020_webcam (failure + cleanup)
    AssertionError: 'qubes-video-companion webcam' exited early (0): b'...

  • TC_00_QVCTest_whonix-gateway-17: test_020_webcam (failure + cleanup)
    AssertionError: 'qubes-video-companion webcam' exited early (0): b'...

  • TC_00_QVCTest_whonix-workstation-17: test_020_webcam (failure + cleanup)
    AssertionError: 'qubes-video-companion webcam' exited early (0): b'...

• system_tests_usbproxy

  • TC_20_USBProxy_core3_fedora-40-xfce: test_070_attach_not_installed_front (error)
    qubesusbproxy.core3ext.QubesUSBException: Device attach failed: 202...

• system_tests_network_updates

  • TC_11_QvmTemplateMgmtVM_debian-12-xfce: test_000_template_list (failure)
    AssertionError: libvirt event impl drain timeout

Unstable tests

• system_tests_audio@hw1

  TC_20_AudioVM_PipeWire_whonix-workstation-17/test_226_audio_playback_pipewire (1/5 times with errors)

  • job 107016 AssertionError: too short audio, expected 10s, got 9.09077097505668...

• system_tests_whonix@hw7

  whonix_torbrowser/ (1/5 times with errors)

  • job 108052 None
  whonix_torbrowser/ (1/5 times with errors)

  • job 108052 None
  whonix_torbrowser/Failed (1/5 times with errors)

  • job 108052 # Test died: no candidate needle with tag(s) 'tor-browser-ipcheck-o...

• system_tests_suspend@hw1

  suspend/ (1/5 times with errors)

  • job 107593 None
  suspend/Failed (1/5 times with errors)

  • job 107593 # Test died: no candidate needle with tag(s) 'xscreensaver-prompt' ...
  suspend/wait_serial (1/5 times with errors)

  • job 107593 # wait_serial expected: qr/2E8vz-\d+-/...

• system_tests_whonix

  whonix_torbrowser/ (1/5 times with errors)

  • job 108052 None
  whonix_torbrowser/ (1/5 times with errors)

  • job 108052 None
  whonix_torbrowser/Failed (1/5 times with errors)

  • job 108052 # Test died: no candidate needle with tag(s) 'tor-browser-ipcheck-o...

• system_tests_suspend

  suspend/ (1/5 times with errors)

  • job 107593 None
  suspend/Failed (1/5 times with errors)

  • job 107593 # Test died: no candidate needle with tag(s) 'xscreensaver-prompt' ...
  suspend/wait_serial (1/5 times with errors)

  • job 107593 # wait_serial expected: qr/2E8vz-\d+-/...

• system_tests_pvgrub_salt_storage

  TC_41_HVMGrub_fedora-40-xfce/test_000_standalone_vm (4/5 times with errors)

  • job 105874 qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
  • job 106585 qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
  • job 107590 qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
  • job 108080 qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

• system_tests_splitgpg

  TC_10_Thunderbird_whonix-workstation-17/test_020_send_receive_inline_with_attachment (2/5 times with errors)

  • job 105876 dogtail.tree.SearchError: descendent of [application | Thunderbird]...
  • job 106587 dogtail.tree.SearchError: descendent of [application | Thunderbird]...

• system_tests_extra

  TC_00_QVCTest_debian-12-xfce/test_020_webcam (1/5 times with errors)

  • job 107031 AssertionError: 'qubes-video-companion webcam' exited early (0): b'...
  TC_00_QVCTest_fedora-40-xfce/test_020_webcam (4/5 times with errors)

  • job 105868 AssertionError: 'qubes-video-companion webcam' exited early (0): b'...
  • job 106579 AssertionError: 'qubes-video-companion webcam' exited early (0): b'...
  • job 107031 AssertionError: 'qubes-video-companion webcam' exited early (0): b'...
  • job 108074 AssertionError: 'qubes-video-companion webcam' exited early (0): b'...
  TC_00_QVCTest_whonix-gateway-17/test_020_webcam (5/5 times with errors)

  • job 105868 AssertionError: 'qubes-video-companion webcam' exited early (0): b'...
  • job 106579 self.assertNotEqual(vm.run('test -e /dev/vid... AssertionError: 0 == 0
  • job 107031 AssertionError: 'qubes-video-companion webcam' exited early (0): b'...
  • job 107584 AssertionError: 'qubes-video-companion webcam' exited early (0): b'...
  • job 108074 AssertionError: 'qubes-video-companion webcam' exited early (0): b'...
  TC_00_QVCTest_whonix-workstation-17/test_020_webcam (3/5 times with errors)

  • job 105868 AssertionError: 'qubes-video-companion webcam' exited early (0): b'...
  • job 106579 self.assertNotEqual(vm.run('test -e /dev/vid... AssertionError: 0 == 0
  • job 107031 AssertionError: 'qubes-video-companion webcam' exited early (0): b'...

• system_tests_network_updates

  TC_10_QvmTemplate_whonix-gateway-17/test_010_template_install (1/5 times with errors)

  • job 105873 AssertionError: libvirt event impl drain timeout

• system_tests_audio

  TC_20_AudioVM_PipeWire_whonix-workstation-17/test_226_audio_playback_pipewire (1/5 times with errors)

  • job 107016 AssertionError: too short audio, expected 10s, got 9.09077097505668...

• system_tests_basic_vm_qrexec_gui_ext4

  TC_20_NonAudio_whonix-workstation-17-pool/test_115_qrexec_filecopy_no_agent (1/5 times with errors)

  • job 108693 libvirt.libvirtError: internal error: libxenlight failed to create ...
  TC_20_NonAudio_whonix-workstation-17-pool/test_130_qrexec_filemove_disk_full (1/5 times with errors)

  • job 108693 libvirt.libvirtError: internal error: libxenlight failed to create ...
  TC_20_NonAudio_whonix-workstation-17-pool/test_140_qrexec_filecopy_unsafe_name (1/5 times with errors)

  • job 108693 libvirt.libvirtError: internal error: libxenlight failed to create ...
  TC_20_NonAudio_whonix-workstation-17-pool/test_141_qrexec_filecopy_unsafe_symlink (1/5 times with errors)

  • job 108693 libvirt.libvirtError: internal error: libxenlight failed to create ...
  TC_20_NonAudio_whonix-workstation-17-pool/test_200_timezone (1/5 times with errors)

  • job 108693 None
  TC_20_NonAudio_whonix-workstation-17-pool/test_210_time_sync (1/5 times with errors)

  • job 108693 None
  TC_20_NonAudio_whonix-workstation-17-pool/test_250_resize_private_img (1/5 times with errors)

  • job 108693 libvirt.libvirtError: internal error: libxenlight failed to create ...
  TC_20_NonAudio_whonix-workstation-17-pool/test_300_bug_1028_gui_memory_pinning (1/5 times with errors)

  • job 108693 libvirt.libvirtError: internal error: libxenlight failed to create ...