-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add -o/--open-at option to global config #227
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #227 +/- ##
==========================================
- Coverage 93.72% 93.42% -0.31%
==========================================
Files 57 57
Lines 10845 10999 +154
==========================================
+ Hits 10165 10276 +111
- Misses 680 723 +43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Added some simple tests, will also include test in a big openqa test I'm writing. |
PipelineRetry |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024111418-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024091704-4.3&flavor=update
Failed tests5 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/112766#dependencies 201 fixed
Unstable tests
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would most probably conflict with my PR for adding Open URL default action setting
. in URL Page. Specifically the glade file. But no worries.
34ad492
to
b6a318d
Compare
Enable opening global config at one of the predefined locations. See readme or code for the list of those. references QubesOS/qubes-issues#9530
When opening template repo settings, open at those template repo settings, and not at the "General" page. fixes QubesOS/qubes-issues#9530 requires QubesOS/qubes-desktop-linux-manager#227
* origin/pr/397: Open global config from template gui at correct location Pull request description: When opening template repo settings, open at those template repo settings, and not at the "General" page. fixes QubesOS/qubes-issues#9530 requires QubesOS/qubes-desktop-linux-manager#227
Enable opening global config at one of the predefined locations. See readme or code for the list of those.
references QubesOS/qubes-issues#9530