Colors overhaul #11
Merged
Colors overhaul #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a perceptual color space instead of HSV when colorizing window decorations, and retain more of the original decorations' lightness. This makes most decorations slightly less dark, improving contrast, removes the need for specialcasing black, and fixes the treatment of gray. In addition, try to determine light/dark text color depending on the original window manager theme. Most themes should look OK now. See QubesOS/qubes-issues#5800.
|
I tweaked the colors slightly to improve contrast for white inactive title. Still doesn't look great for all xfce themes, but then some xfce themes look pretty bad even before we modify them :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New version of #7.
Use a perceptual color space instead of HSV when colorizing
window decorations, and retain more of the original decorations'
lightness. This makes most decorations slightly less dark,
improving contrast, removes the need for specialcasing black,
and fixes the treatment of gray.
In addition, try to determine light/dark color depending on the
original window manager theme. Most themes should look OK now.
See QubesOS/qubes-issues#5800.
Examples
Note that the title bars in the screenshots are inactive (only the dom0 window has focus). Active titles have darker/lighter text, resulting in better contrast. (edit: the inactive title colors have also been improved slightly since taking the screenshot)
Default theme (in R4.1 currently):
Default theme (in this PR):
Other themes (in this PR):