-
-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce Windows confusion in renamed 'Install medium prep' section #1174
Conversation
It's unclear to me why the htmlproofer check failed in the pipeline. I'm happy to fix if someone would kindly suggest how. |
@marmarek, @fepitre: Did htmlproofer run out of memory again? |
PipelineRetry |
Thanks, @fepitre! Ok, it looks like all of the failures in the CI log are accurate and specific to this PR now, @dksmiffs:
|
Tag for commit 6eea2bf # -----BEGIN PGP SIGNATURE----- # # iQIzBAABCgAdFiEE4R0VxtIENXaf+qRWjOE3NSoBmhcFAmDqGVAACgkQjOE3NSoB # mhcsdg/6A2zT+GvdR0XtnGxyJoI1WDTHrTSt9e0BiVOWorCs1OoL85leR0jvzWgO # hcXeIxiQK7EnG/QKQC1UMY3gSfL+t8bkaGlXVqcNPFdbVIiHqg/w0KuMaA1pq4mQ # slGtcZyQjjWLLm8RiL4KxshnqVZWqokQwOg3GwL72bNvVxOGb5nJAI9VIyq9+C6N # rqE3qUg3CkzVUxjEFh8kNjGGc/SrpWRlXDHr/6+L5BgGKGcXjhy3S480yRNHU5LI # V/xqkFa+QJaA5F0E+2CIX+fuHSQGl8HrupdXltBRT4VYTibLICGAPsiibpETSrNX # f0lPXUfJAQINw9MAWEvypuFhCHc21xwV/KHVymGuUsbLVFsSUDFrAimb9zBxvqRC # MNAnIBcwrvgxBBg2P4XVTLaV6fKe8vGf3fuiV0Rlxpjk/5oq8KKwCc9LeSd1Q+Sq # hHV72j/yOpXe/FJ10eWMJQLoOGUk/aMu8gAhpjSMBzuDV9kmwp3H2eNNrTrU3hxW # UAvSaNTCK+klmNTWfiPKDaQCtJFhrBqglzo/yNo0JUBhpP6azZ41ISU9pd9lamc5 # kbBWioRjeb6hQ+aBgU6W2UY+q9S6gyvITpfB+PmjU+HzCUqoxpKKe2epQnnm63Tn # 46eceH/DdlFWZcRP0Zi2aMsdyylwRaGVoRASwb90JKRtfVSEd58= # =gYJ6 # -----END PGP SIGNATURE----- # gpg: Signature made 7/10/2021 5:04:00 PM Central Daylight Time # gpg: using RSA key E11D15C6D20435769FFAA4568CE137352A019A17 # gpg: Can't check signature: No public key
<b>Note:</b> If you do this on Windows 10, you can only install Qubes | ||
without MediaTest, which is not recommended. | ||
<b>Note:</b> Choosing this Windows+Rufus method means that you | ||
[won't be able](https://github.com/QubesOS/qubes-issues/issues/2051) to choose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Markdown syntax won't work here, because you're inside of an alert. Has to be HTML.
I actually still don't even know what |
On Sun, Jul 11, 2021 at 10:34:41PM -0700, Andrew David Wong wrote:
I actually still don't even know what `MediaTest` is. Should that be explained somewhere? Is it just an odd way of referring to the option in the Qubes installer to test the installation medium? (I say "odd" because I don't recall the term `MediaTest` being used, but my memory often fails me.)
Yes, it's just an odd reference to the "Test this media" option at
installation. Not used anywhere else, I dont think.
|
@andrewdavidwong yes, made even more confusing by the CamelCase usage, which leads the reader to believe it might be an intentional thing (I agree with @unman, I think it should not be). This one odd reference was the origin of this PR for me. |
Appears to be the same failure that @andrewdavidwong commented on above on 7/8. |
PipelineRetry |
Ok so it looks like we still have an issue with one of the runner. I've retried with the failing runner disabled. Sorry for the problem. |
installation medium of your choice, such as a USB drive, dual-layer DVD, | ||
or Blu-ray disc. The size of each Qubes ISO is available on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reordered list to put most common and recommended medium first.
<div class="alert alert-info" role="alert"> | ||
<i class="fa fa-info-circle"></i> | ||
<b>Note:</b> Using Rufus to create the installation medium means that you | ||
<a href="https://github.com/QubesOS/qubes-issues/issues/2051">won't be able</a> | ||
to choose the "Test this media & install Qubes" option recommended in the | ||
Installation section below. Instead, you'll only be able to choose the | ||
"Install Qubes" option. | ||
to choose the "Test this media and install Qubes OS" option mentioned in the | ||
example below. Instead, choose the "Install Qubes OS" option. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't deserve "warning" (as opposed to "info"), because the "test this media" option isn't being "recommended" below. As it states at the beginning of that section, it's simply showing you an example with the most common settings.
The previous wording is likely to get users worried over nothing. This alert still might. Many users still won't understand it at all and become terribly confused. I'm of half a mind to remove it, but it's reasonable to let users know that using Rufus will disallow the test option, since they might care about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrewdavidwong I like your wording better, and I agree with you about not getting users worried over nothing. I think your wording definitely lessens potential worry.
Seems like there's no CI check at all now. Is that expected? |
PipelineRetry |
No. Unfortunately, there is some recent random issue with Gitlab/Github CI events that we catch to report status. I still don't find why there is such failure yet. |
As discussed w/ adw and deeplow here from 2021-06-27 through 06-30, and an attempted improvement to prior (now closed) PR #1168. Again, I welcome suggestions for improvement to this edit.