Remove coreboot detection, add skip_grub parameter #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marmarek
requested changes
Apr 27, 2017
anaconda/pyanaconda/bootloader.py
Outdated
| self.stage2_format_types += ["lvmlv"] | ||
| self.encryption_support = True | ||
| self.stage2_format_types += ["lvmlv"] | ||
| self.skip_bootloader = bool(int(flags.cmdline.get("skip_grub") or "0")) |
There was a problem hiding this comment.
Better use flags.cmdline.getbool("skip_grub", False)
And unconditionally allow boot encryption and the lvmlv format. (The user still has to fight the installer to actually set it up.) Fixes QubesOS/qubes-issues#2553
rustybird
changed the title
|
Fixed. Booting with/without |
marmarek
approved these changes
May 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successfully tested the following scenarios with the R3.2 iso:
skip_grub=1, following instructions from Full encrypted disk support on coreboot/libreboot BIOS machines qubes-issues#2118 (comment)skip_grubparameter, default installation layoutskip_grubparameter, btrfs installation layout (generated by Anaconda)The dmidecode package could be removed now, but they still seem like useful tools to have for debugging installer problems.