Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No help text or man page for qvm-console-dispvm #8019

Closed
andrewdavidwong opened this issue Feb 7, 2023 · 7 comments · Fixed by QubesOS/qubes-core-admin#605
Closed

No help text or man page for qvm-console-dispvm #8019

andrewdavidwong opened this issue Feb 7, 2023 · 7 comments · Fixed by QubesOS/qubes-core-admin#605
Labels
affects-4.1 This issue affects Qubes OS 4.1. C: core C: doc diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.

Comments

@andrewdavidwong
Copy link
Member

How to file a helpful issue

Qubes OS release

4.1.1

Brief summary

There's no help text or man page for qvm-console-dispvm.

Steps to reproduce

In dom0:

$ qvm-console-dispvm --help
Invalid qube name --help
$ qvm-console-dispvm -h
Invalid qube name -h
$ man qvm-console-dispvm
No manual entry for qvm-console-dispvm

Expected behavior

Help text and a man page.

Actual behavior

Neither.

@andrewdavidwong andrewdavidwong added T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. C: core C: doc P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. labels Feb 7, 2023
@andrewdavidwong andrewdavidwong added this to the Release 4.1 updates milestone Feb 7, 2023
@unman
Copy link
Member

unman commented Feb 10, 2023 via email

@andrewdavidwong
Copy link
Member Author

andrewdavidwong commented Feb 11, 2023

There is, of course, help available on calling qvm-console-dispvm

I'm not comfortable with executing a command in dom0 without first having some idea of what it will do. Having to execute a command without any arguments in order to get the help text feels a bit shooting first and asking questions later. Also, since not every command works this way, it's not a reliable approach. Some commands will just immediately perform an action (potentially an irreversible action that you don't want).

@DemiMarie
Copy link

Some commands will just immediately perform an action (potentially an irreversible action that you don't want).

Are there any such commands in dom0? There really should not be.

@andrewdavidwong
Copy link
Member Author

Some commands will just immediately perform an action (potentially an irreversible action that you don't want).

Are there any such commands in dom0? There really should not be.

qubes-dom0-update, for example, and potentially any non-Qubes command.

@DemiMarie
Copy link

Some commands will just immediately perform an action (potentially an irreversible action that you don't want).

Are there any such commands in dom0? There really should not be.

qubes-dom0-update, for example, and potentially any non-Qubes command.

qubes-dom0-update gives you a prompt and the default is to cancel.

@unman
Copy link
Member

unman commented Feb 12, 2023 via email

@andrewdavidwong
Copy link
Member Author

But it has performed significant actions first, before it gets to the "prompt" stage.

Yes, exactly.

qubes-dom0-update gives you a prompt and the default is to cancel.

I think you're getting caught up on the specifics of one example and missing the point. The point really isn't whether, as a contingent matter of fact, there happen to be any such commands in dom0 right now. The point is that even experienced Linux users can't know exactly what a novel command will do from its name alone. If they try to find out what the command does by checking for help text and a man page and come up empty-handed, they shouldn't then be required to take a gamble and execute the command blindly in the hope that it will finally reveal its secrets (such as its basic function). It's just bad practice.

@andrewdavidwong andrewdavidwong added the affects-4.1 This issue affects Qubes OS 4.1. label Aug 8, 2023
@andrewdavidwong andrewdavidwong removed this from the Release 4.1 updates milestone Aug 13, 2023
alimirjamali added a commit to alimirjamali/qubes-core-admin that referenced this issue Jul 4, 2024
marmarek pushed a commit to QubesOS/qubes-core-admin that referenced this issue Jul 6, 2024
@andrewdavidwong andrewdavidwong added diagnosed Technical diagnosis has been performed (see issue comments). pr submitted A pull request has been submitted for this issue. labels Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-4.1 This issue affects Qubes OS 4.1. C: core C: doc diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants