Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devices widget: Label recently-connected devices as "NEW" #8543

Closed
jamke opened this issue Sep 22, 2023 · 3 comments · Fixed by QubesOS/qubes-desktop-linux-manager#207
Closed
Labels
C: manager/widget P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue. T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality. ux User experience

Comments

@jamke
Copy link

jamke commented Sep 22, 2023

The problem you're addressing (if any)

Search for new devices in the devices widget can be easy and reliable.
Currently it is not easy and the chance of mistake, selection of wrong device, is high.

This can lead to a security leak in case the USB device is a USB-Ethernet connector or other network device connected to vault or any offline qube by mistake.

The most common user case:

  • User inserts USB device in USB slot
  • User opens devices widget
  • User manually search among devices (block or not) for the new just-inserted device.

This user case has 2 problems:

  1. User has to manually search though the list reading everything
  2. The chance of mistake, selection of wrong device, is high.

The solution you'd like

How about showing some label or icon "NEW" near device name in the list that

  • was not show in the previous time widget was open, and
  • was inserted in the last, let's say, 10 minutes.

The device should stay NEW after being shown for the first time for some small time like a minute to prevent it from loosing NEW icon after opening the widget menu fast twice.

Also connecting device to any qube should instantly make the device not NEW.

The value to a user, and who that user might be

It should cover the most common case: user inserts device (block device or not) and tries to connect it somewhere. He will instantly find the connected device. And no spoofing is possible if the system can process events of connections and disconnections.

When I think about it, I do not know why isn't it a case in all OSes yet.

@jamke jamke added P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality. labels Sep 22, 2023
@jamke jamke changed the title Searching for connected devices in the widget can be easy and reliable with a NEW label Search for connected devices in the Devices widget can be easy and reliable with a NEW label Sep 22, 2023
@andrewdavidwong andrewdavidwong changed the title Search for connected devices in the Devices widget can be easy and reliable with a NEW label Devices widget: Label recently-connected devices as "NEW" Sep 22, 2023
@marmarta marmarta removed their assignment Mar 6, 2024
@alimirjamali
Copy link

alimirjamali commented Jul 5, 2024

I am working on this. Bellow is the screenshot of the patch (so far).

We have to decide if the 10 minute timeout is OK or is too much. I personally prefer it to be shorter. And also decide if the timeout has to be configurable; perhaps by adding a special feature key to the host.

NEW_DEVICE

p.s.: Related discussion on forum. No user has asked the timeout period to be configurable (or option to disable it). I guess 10 minutes after connection, 2 minutes after 1st view is fine.

@jamke
Copy link
Author

jamke commented Jul 12, 2024

Thank you for addressing my proposal! I was not expecting it to be implemented anytime soon, nice surprise.

About timeout choosing problem, and your opinion that 10 minutes can be too big. I kind of agree and have another idea.

How about having small timeout like 1 minute - show NEW red label and after 1 minute just show time if was connected for the last time, something like 3 min ago, or 5 hours ago and so on? The color should be more neutral obviously, like gray.
The devices that were available from the boot can be marked since boot or have nothing.
The gray color will make it look not dragging attention too much and everything would be informative and great.

@marmarta
Copy link
Member

I don't think a red label is ever appropriate here - red is bad and dangerous usually, I much prefer the blue we settled on.

The time idea is interesting! I think it could work, or maybe it could be shown in the details about the device when device details are shown...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: manager/widget P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue. T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality. ux User experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants