-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Devices widget: Label recently-connected devices as "NEW" #8543
Devices widget: Label recently-connected devices as "NEW" #8543
Comments
I am working on this. Bellow is the screenshot of the patch (so far). We have to decide if the 10 minute timeout is OK or is too much. I personally prefer it to be shorter. And also decide if the timeout has to be configurable; perhaps by adding a special feature key to the host. p.s.: Related discussion on forum. No user has asked the timeout period to be configurable (or option to disable it). I guess 10 minutes after connection, 2 minutes after 1st view is fine. |
Thank you for addressing my proposal! I was not expecting it to be implemented anytime soon, nice surprise. About timeout choosing problem, and your opinion that 10 minutes can be too big. I kind of agree and have another idea. How about having small timeout like 1 minute - show NEW red label and after 1 minute just show time if was connected for the last time, something like 3 min ago, or 5 hours ago and so on? The color should be more neutral obviously, like gray. |
I don't think a red label is ever appropriate here - red is bad and dangerous usually, I much prefer the blue we settled on. The time idea is interesting! I think it could work, or maybe it could be shown in the details about the device when device details are shown... |
fixes: QubesOS/qubes-issues#8543 (cherry picked from commit 4333b8f)
The problem you're addressing (if any)
Search for new devices in the devices widget can be easy and reliable.
Currently it is not easy and the chance of mistake, selection of wrong device, is high.
This can lead to a security leak in case the USB device is a USB-Ethernet connector or other network device connected to vault or any offline qube by mistake.
The most common user case:
This user case has 2 problems:
The solution you'd like
How about showing some label or icon "NEW" near device name in the list that
The device should stay NEW after being shown for the first time for some small time like a minute to prevent it from loosing NEW icon after opening the widget menu fast twice.
Also connecting device to any qube should instantly make the device not NEW.
The value to a user, and who that user might be
It should cover the most common case: user inserts device (block device or not) and tries to connect it somewhere. He will instantly find the connected device. And no spoofing is possible if the system can process events of connections and disconnections.
When I think about it, I do not know why isn't it a case in all OSes yet.
The text was updated successfully, but these errors were encountered: