Create new qube: Template has network by default

[deeplow]

How to file a helpful issue

The problem you're addressing (if any)

When we create a new template qube (e.g. via clone), this is what the settings look like when one clicks on the template tab (notice the network part)

The solution you'd like

When clicking the template tab No network connection should be the default option. This probably is not the case due to the network connection being "saved" from the previous (default) tab which are app qubes.

The value to a user, and who that user might be

Foot-shooting prevention.

Completion criteria checklist

(This section is for developer use only. Please do not modify it.)

[alimirjamali]

OK. The question is if this has to be fixed at admin.vm.Create core API level or at GUI end level.
p.s.: The answer is at GUI level. Creating a Template via Admin API does not associate a netvm to the Template

Sub-tasks:

• Fix the legacy Qt based Qubes Manager's Create Qubes VM (i.e. qubes-vm-create)
• Fix the new GTK based Create New Qube (i.e. qubes-new-qube)

[marmarek]

The answer is at GUI level

Yes, the GUI needs to show accurate info before creating the qube.

[alimirjamali]

PR for sub-task 1 is submitted.

Review priority: low

It changes the ComboBoxes for Template & Networking to (none) if you select TemplateVM in the 1st combo box. It also locks the Template ComboBox to (none) if TemplateVM is selected. They are reverted to their default value if user selects another type. Here is the video:

qubes-vm-create.mp4

[marmarek]

I don't think locking is appropriate, it's a valid choice to make network-connected template if one really wants that (for example it's kinda-necessary for Windows to be able to install updates there).

Anyway, for the old create qube dialog, I would prefer to simply remove it (and make qubes manager use the new one). Focus on the new one.

[alimirjamali]

I don't think locking is appropriate, it's a valid choice to make network-connected template if one really wants that (for example it's kinda-necessary for Windows to be able to install updates there).

Locking is done only for the middle ComboBox (the Template: ComboBox). Not for Networking.

Anyway, for the old create qube dialog, I would prefer to simply remove it (and make qubes manager use the new one). Focus on the new one.

Sure. Will be done soon.

[marmarek]

Locking is done only for the middle ComboBox (the Template: ComboBox). Not for Networking.

Ah, okay, makes sense.

[alimirjamali]

Development notes:
Type change detection could be done via CreateNewQube._type_selected. The button_name for Templates is qube_type_template. Doing it via self.network_selector.network_none.set_active(True) is insufficient as it results on the Template netvm to be None instead of being unset. This behaviour will be changed only for new Templates.

[alimirjamali]

PR for sub-task 2 (main task) is submitted

Review priority: low

Video:

qubes-new-qube.mp4