Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dom0 doesn’t send empty MSG_DATA_STDERR #9248

Closed
DemiMarie opened this issue May 19, 2024 · 0 comments · Fixed by QubesOS/qubes-core-qrexec#164
Closed

dom0 doesn’t send empty MSG_DATA_STDERR #9248

DemiMarie opened this issue May 19, 2024 · 0 comments · Fixed by QubesOS/qubes-core-qrexec#164
Labels
affects-4.2 This issue affects Qubes OS 4.2. C: core diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.

Comments

@DemiMarie
Copy link

How to file a helpful issue

Qubes OS release

R4.2

Brief summary

dom0 doesn’t send data on stderr, but also doesn’t send an empty MSG_DATA_STDERR to indicate EOF. As with #9142, this should be sent for consistency.

Steps to reproduce

  1. Connect to a service in dom0.
  2. Observe what happens to stderr.

Expected behavior

I think an empty MSG_DATA_STDERR should be sent as an EOF marker, since no data on stderr will ever be sent.

Actual behavior

No MSG_DATA_STDERR sent at all.
@DemiMarie DemiMarie added T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. labels May 19, 2024
DemiMarie added a commit to DemiMarie/qubes-core-qrexec that referenced this issue May 19, 2024
@DemiMarie
Always send EOF on streams
586cd9c 
Previously, this was not guaranteed to happen if the process was
exiting, and MSG_DATA_STDERR would not be sent for socket services at
all.

Fixes: QubesOS/qubes-issues#9142
Fixes: QubesOS/qubes-issues#9248
Fixes: QubesOS/qubes-issues#9249
DemiMarie added a commit to DemiMarie/qubes-core-qrexec that referenced this issue May 19, 2024
@DemiMarie
Always send EOF on streams
0c24064 
Previously, this was not guaranteed to happen if the process was
exiting, and MSG_DATA_STDERR would not be sent for socket services at
all.

Fixes: QubesOS/qubes-issues#9142
Fixes: QubesOS/qubes-issues#9248
Fixes: QubesOS/qubes-issues#9249
@DemiMarie DemiMarie mentioned this issue May 19, 2024
Merged
@andrewdavidwong andrewdavidwong added C: other diagnosed Technical diagnosis has been performed (see issue comments). affects-4.2 This issue affects Qubes OS 4.2. C: core and removed C: other labels May 19, 2024
DemiMarie added a commit to DemiMarie/qubes-core-qrexec that referenced this issue May 19, 2024
@DemiMarie
Always send EOF on stderr
7851fae 
Previously, this was not guaranteed to happen if the process was
exiting, and MSG_DATA_STDERR would not be sent for socket services at
all.  There is still a case where an empty MSG_DATA_STDOUT might not be
sent.

Fixes: QubesOS/qubes-issues#9142
Fixes: QubesOS/qubes-issues#9248
This was referenced Jun 14, 2024
Closed
Closed
Closed
@andrewdavidwong andrewdavidwong added the pr submitted A pull request has been submitted for this issue. label Jun 16, 2024
@qubesos-bot qubesos-bot mentioned this issue Jun 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-4.2 This issue affects Qubes OS 4.2. C: core diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Always send EOF on streams DemiMarie/qubes-core-qrexec
2 participants
@DemiMarie @andrewdavidwong