Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bogus error message when working with service beginning with numeral #9274

Closed
unman opened this issue May 30, 2024 · 0 comments
Closed

Bogus error message when working with service beginning with numeral #9274

unman opened this issue May 30, 2024 · 0 comments
Labels
affects-4.2 This issue affects Qubes OS 4.2. C: core diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue. r4.2-host-stable r4.3-host-cur-test T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.

Comments

@unman
Copy link
Member

unman commented May 30, 2024

How to file a helpful issue

Qubes OS release

4.2

Brief summary

Reported by jbb in Forum:
When I enable the service in dom0 terminal or through the Qube Manager gui, I get an error message saying "service name must start with an ASCII character".
It appears the service is still running on the vm, but the message pops up again any time I apply edits to the VM settings in Qube Manager.

Steps to reproduce

  1. Install service where name begins with numeral
  2. Attempt to enable service using qvm-service or in qube settings GUI.

Expected behavior

Service will be enabled without issue.

Actual behavior

Service IS enabled but Error Message appears:
"service name must start with an ASCII character"

AFAIK there is no restriction on beginning service names with numeral.
The error message is obviously bogus, and should not appear at all, since the service is correctly enabled/disabled.

@andrewdavidwong andrewdavidwong added T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. C: core P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. diagnosed Technical diagnosis has been performed (see issue comments). pr submitted A pull request has been submitted for this issue. affects-4.2 This issue affects Qubes OS 4.2. labels May 31, 2024
marmarek added a commit to marmarek/qubes-core-admin that referenced this issue Jun 12, 2024
This applies to '.', '..' and anything with a slash.
Technically those services can still be accessible via qubesdb, but
that's not really intuitive and may look like a silent failure.
But since technically those can be seen by a VM, do not exclude them
from qubesdb, if somebody already set some of those names. Refuse only
new values.

QubesOS/qubes-issues#9274
marmarek added a commit to QubesOS/qubes-core-admin that referenced this issue Jun 25, 2024
Conditions checked here are bogus (the only relevant one is length).
Furthermore it's done in wrong place (should be pre- event).

This reverts commit a3aea50.

Fixes QubesOS/qubes-issues#9274

(cherry picked from commit 0ec452e)
marmarek added a commit to QubesOS/qubes-core-admin that referenced this issue Jun 25, 2024
This applies to '.', '..' and anything with a slash.
Technically those services can still be accessible via qubesdb, but
that's not really intuitive and may look like a silent failure.
But since technically those can be seen by a VM, do not exclude them
from qubesdb, if somebody already set some of those names. Refuse only
new values.

QubesOS/qubes-issues#9274

(cherry picked from commit 1ff10c9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-4.2 This issue affects Qubes OS 4.2. C: core diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue. r4.2-host-stable r4.3-host-cur-test T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Projects
None yet
Development

No branches or pull requests

3 participants