Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qubes OS Updater: additional update check after n days does not work #9427

Closed
rapenne-s opened this issue Aug 21, 2024 · 3 comments · Fixed by QubesOS/qubes-desktop-linux-manager#218
Closed

Qubes OS Updater: additional update check after n days does not work #9427

rapenne-s opened this issue Aug 21, 2024 · 3 comments · Fixed by QubesOS/qubes-desktop-linux-manager#218
Assignees
@alimirjamali
Labels
affects-4.2 This issue affects Qubes OS 4.2. C: manager/widget C: updates diagnosed Technical diagnosis has been performed (see issue comments). P: major Priority: major. Between "default" and "critical" in severity. pr submitted A pull request has been submitted for this issue. r4.3-host-cur-test T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.

Comments

@rapenne-s
Copy link

Qubes OS release

R4.2.2

Brief summary

The Qubes OS Updater GUI have a feature named "additional update check" to look for updates after n days in case a template is never used. This does not seem to work.

Steps to reproduce

Have a template VM used by a qube, do not start the qube within n days, wait for the qubes os updater GUI to show up, the qube should never be selected for update.

Expected behavior

qubes with a "last checked" date older than n days should automatically be checked for update.

Actual behavior

templates can be left forever without updates

the screenshot was taken 2024-08-21 and there should be an attempt to update qubes after 5 days per the configuration

extra_check
@rapenne-s rapenne-s added P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. labels Aug 21, 2024
@andrewdavidwong andrewdavidwong changed the title Qubes OS Updater: addition update check after n days does not work Qubes OS Updater: additional update check after n days does not work Aug 21, 2024
@andrewdavidwong andrewdavidwong added affects-4.2 This issue affects Qubes OS 4.2. C: manager/widget needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. C: updates P: major Priority: major. Between "default" and "critical" in severity. and removed P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. labels Aug 21, 2024
marmarek added a commit to marmarek/qubes-core-admin that referenced this issue Aug 23, 2024
@marmarek
qubesd: use server.close_clients()
56ffdea 
Python 3.12+ fixed server.wait_closed() to really wait for all the
connections to terminate. This causes qubesd to hang on shutdown, as
events connections were not closed. Python 3.13 introduces convenient
server.close_clients() function to close all connections.

There was a similar code in tests already - convert that to
close_clients() call too.

Fixes QubesOS/qubes-issues#9427
marmarek added a commit to marmarek/qubes-core-admin that referenced this issue Aug 23, 2024
@marmarek
qubesd: use server.close_clients()
d1aed7a 
Python 3.12+ fixed server.wait_closed() to really wait for all the
connections to terminate. This causes qubesd to hang on shutdown, as
events connections were not closed. Python 3.13 introduces convenient
server.close_clients() function to close all connections.

There was a similar code in tests already - convert that to
close_clients() call too.

Fixes QubesOS/qubes-issues#9427
@marmarek marmarek reopened this Aug 24, 2024
alimirjamali added a commit to alimirjamali/qubes-desktop-linux-manager that referenced this issue Aug 24, 2024
@alimirjamali
Select stale qubes for update too
ea821a5 
fixes: QubesOS/qubes-issues#9427
@alimirjamali alimirjamali mentioned this issue Aug 24, 2024
Merged
@alimirjamali
Copy link

PR Submitted

Review priority: Medium

@alimirjamali
Copy link

alimirjamali commented Aug 24, 2024 •
edited
Loading

Related: #8511

p.s.: This fix should practically resolve #8511 as well. Technically MAYBE is stale.

@qubesos-bot qubesos-bot mentioned this issue Aug 24, 2024
Closed
@andrewdavidwong andrewdavidwong added diagnosed Technical diagnosis has been performed (see issue comments). pr submitted A pull request has been submitted for this issue. and removed needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. labels Aug 25, 2024
@rapenne-s
Copy link
Author

alimirjamali/qubes-desktop-linux-manager@82a35ba fixes the problem, although I did not try the test as I do not know how to run them. I applied the one line change manually in dom0 :(

@qubesos-bot qubesos-bot mentioned this issue Nov 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alimirjamali alimirjamali

Labels
affects-4.2 This issue affects Qubes OS 4.2. C: manager/widget C: updates diagnosed Technical diagnosis has been performed (see issue comments). P: major Priority: major. Between "default" and "critical" in severity. pr submitted A pull request has been submitted for this issue. r4.3-host-cur-test T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Select stale qubes for update too alimirjamali/qubes-desktop-linux-manager
5 participants
@rapenne-s @marmarek @alimirjamali @andrewdavidwong @qubesos-bot