Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qubesd doesn't stop on SIGTERM #9429

Closed
marmarek opened this issue Aug 22, 2024 · 0 comments · Fixed by QubesOS/qubes-core-admin#615
Closed

qubesd doesn't stop on SIGTERM #9429

marmarek opened this issue Aug 22, 2024 · 0 comments · Fixed by QubesOS/qubes-core-admin#615
Labels
affects-4.3 This issue affects Qubes OS 4.3. C: core diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.

Comments

@marmarek
Copy link
Member

How to file a helpful issue

Qubes OS release

R4.3

Brief summary

When sending SIGTERM to qubesd, it doesn't stop. Sending a second SIGTERM does stop it, but not cleanly (RuntimeError: Event loop stopped before Future completed).

Steps to reproduce

  1. systemctl stop qubesd or send SIGTERM to qubesd manually

Expected behavior

It stops cleanly

Actual behavior

It appears to do some cleanup, at least strace says it stops listening on sockets and unlinks them. But the process doesn't terminate.
When stopping qubesd service via systemd, it will get SIGABRT after a timeout and it will terminate then. This also delays system shutdown.

I guess it may be related to update from Python 3.11 to 3.13.

@marmarek marmarek added T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. C: core P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. affects-4.3 This issue affects Qubes OS 4.3. labels Aug 22, 2024
@marmarek marmarek self-assigned this Aug 22, 2024
@marmarek marmarek moved this to In progress in Current team tasks Aug 22, 2024
@marmarek marmarek moved this from In progress to Ready in Current team tasks Aug 22, 2024
@marmarek marmarek removed their assignment Aug 22, 2024
@github-project-automation github-project-automation bot moved this from Ready to Done in Current team tasks Aug 24, 2024
@andrewdavidwong andrewdavidwong added diagnosed Technical diagnosis has been performed (see issue comments). pr submitted A pull request has been submitted for this issue. and removed needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. labels Aug 25, 2024
fepitre pushed a commit to fepitre/qubes-core-qrexec that referenced this issue Sep 4, 2024
Previously, if a service with exit-on-client-eof=true received EOF on
stdin while stdout was still open, no EOF would be sent on stdout.  This
is a (currently harmless) violation of the qrexec protocol.  Fix this by
sending an empty MSG_DATA_STDOUT to indicate EOF on stdout.

Fixes: QubesOS/qubes-issues#9429
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-4.3 This issue affects Qubes OS 4.3. C: core diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants