Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Backup toggle in Qube Manager #413

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alimirjamali
Copy link
Contributor

Currently only unsets the backup check. Could not set it back.

Currently only unsets the backup check. Could not set it back.
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.50%. Comparing base (918b8d2) to head (531dd89).

Files with missing lines Patch % Lines
qubesmanager/qube_manager.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #413      +/-   ##
==========================================
- Coverage   68.55%   68.50%   -0.06%     
==========================================
  Files          17       17              
  Lines        3762     3762              
==========================================
- Hits         2579     2577       -2     
- Misses       1183     1185       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@qubesos-bot
Copy link

qubesos-bot commented Mar 13, 2025

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025031300-4.3&flavor=pull-requests

Test run included the following:

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025021804-4.3&flavor=update

  • system_tests_whonix

  • system_tests_extra

    • TC_00_QVCTest_whonix-gateway-17: test_010_screenshare (failure)
      ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^... AssertionError: 0 == 0
  • system_tests_kde_gui_interactive

    • gui_keyboard_layout: wait_serial (wait serial expected)
      # wait_serial expected: "echo -e '[Layout]\nLayoutList=us,de' | sud...

    • gui_keyboard_layout: Failed (test died)
      # Test died: command 'test "$(cd ~user;ls e1*)" = "$(qvm-run -p wor...

  • system_tests_whonix@hw7

  • system_tests_qwt_win11@hw13

    • windows_install: Failed (test died)
      # Test died: command 'qvm-create-windows-qube -i Win11_24H2_Englis...
  • system_tests_qwt_win10_seamless@hw13

    • windows_install: Failed (test died)
      # Test died: command 'qvm-create-windows-qube --seamless -i Win10_2...
  • system_tests_basic_vm_qrexec_gui_zfs

    • TC_03_QvmRevertTemplateChanges: test_000_revert_linux (error)
      subprocess.CalledProcessError: Command '['sha1sum', '/dev/zvol/test...
  • system_tests_qwt_win10@hw13

    • windows_clipboard_and_filecopy: unnamed test (unknown)
    • windows_clipboard_and_filecopy: Failed (test died)
      # Test died: no candidate needle with tag(s) 'menu-vm-windows-test'...

Failed tests

20 failures
  • system_tests_whonix

    • whonixcheck: fail (unknown)
      Whonixcheck for anon-whonix failed...

    • whonixcheck: unnamed test (unknown)

    • whonixcheck: fail (unknown)
      Whonixcheck for sys-whonix failed...

    • whonixcheck: unnamed test (unknown)

  • system_tests_extra

    • TC_00_QVCTest_whonix-gateway-17: test_010_screenshare (failure)
      ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^... AssertionError: 0 == 0
  • system_tests_kde_gui_interactive

    • gui_keyboard_layout: wait_serial (wait serial expected)
      # wait_serial expected: "echo -e '[Layout]\nLayoutList=us,de' | sud...

    • gui_keyboard_layout: Failed (test died)
      # Test died: command 'test "$(cd ~user;ls e1*)" = "$(qvm-run -p wor...

  • system_tests_audio

  • system_tests_whonix@hw7

    • whonixcheck: fail (unknown)
      Whonixcheck for anon-whonix failed...

    • whonixcheck: unnamed test (unknown)

    • whonixcheck: fail (unknown)
      Whonixcheck for sys-whonix failed...

    • whonixcheck: unnamed test (unknown)

  • system_tests_suspend@hw1

    • suspend: unnamed test (unknown)
    • suspend: Failed (test died)
      # Test died: no candidate needle with tag(s) 'SUSPEND-FAILED' match...
  • system_tests_qwt_win11@hw13

    • windows_install: Failed (test died)
      # Test died: command 'qvm-create-windows-qube -i Win11_24H2_Englis...
  • system_tests_qwt_win10_seamless@hw13

    • windows_install: Failed (test died)
      # Test died: command 'qvm-create-windows-qube --seamless -i Win10_2...
  • system_tests_basic_vm_qrexec_gui_btrfs

    • TC_03_QvmRevertTemplateChanges: test_000_revert_linux (error)
      subprocess.CalledProcessError: Command '['sha1sum', '/var/lib/qubes...
  • system_tests_basic_vm_qrexec_gui_zfs

    • TC_03_QvmRevertTemplateChanges: test_000_revert_linux (error)
      subprocess.CalledProcessError: Command '['sha1sum', '/dev/zvol/test...
  • system_tests_qwt_win10@hw13

    • windows_clipboard_and_filecopy: unnamed test (unknown)
    • windows_clipboard_and_filecopy: Failed (test died)
      # Test died: no candidate needle with tag(s) 'menu-vm-windows-test'...

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/129058#dependencies

9 fixed
  • system_tests_whonix

  • system_tests_suspend

    • suspend: unnamed test (unknown)
    • suspend: Failed (test died)
      # Test died: no candidate needle with tag(s) 'SUSPEND-FAILED' match...
  • system_tests_qrexec

  • system_tests_kde_gui_interactive

    • clipboard_and_web: unnamed test (unknown)
    • clipboard_and_web: Failed (test died)
      # Test died: no candidate needle with tag(s) 'clipboard-paste-notif...
  • system_tests_audio

    • TC_20_AudioVM_Pulse_whonix-workstation-17: test_223_audio_play_hvm (failure)
      AssertionError: too short audio, expected 10s, got 7.33528344671201...

    • TC_20_AudioVM_PipeWire_whonix-workstation-17: test_226_audio_playback_pipewire (failure)
      AssertionError: too short audio, expected 10s, got 9.19027210884353...

  • system_tests_whonix@hw7

Unstable tests

Performance Tests

Performance degradation:

30 performance degradations
  • debian-12-xfce_exec: 8.47 :small_red_triangle_up: ( previous job: 7.15, degradation: 118.36%)
  • debian-12-xfce_exec-data-simplex: 67.42 :small_red_triangle_up: ( previous job: 48.93, degradation: 137.80%)
  • debian-12-xfce_exec-data-duplex: 61.85 :small_red_triangle_up: ( previous job: 50.76, degradation: 121.84%)
  • debian-12-xfce_exec-data-duplex-root: 80.95 :small_red_triangle_up: ( previous job: 64.91, degradation: 124.71%)
  • debian-12-xfce_socket-data-duplex: 159.62 :small_red_triangle_up: ( previous job: 81.49, degradation: 195.88%)
  • fedora-41-xfce_exec-data-simplex: 61.12 :small_red_triangle_up: ( previous job: 49.65, degradation: 123.10%)
  • fedora-41-xfce_exec-data-duplex: 64.96 :small_red_triangle_up: ( previous job: 49.08, degradation: 132.35%)
  • fedora-41-xfce_exec-data-duplex-root: 106.74 :small_red_triangle_up: ( previous job: 81.65, degradation: 130.73%)
  • fedora-41-xfce_socket-data-duplex: 140.00 :small_red_triangle_up: ( previous job: 78.62, degradation: 178.07%)
  • whonix-gateway-17_socket: 8.34 :small_red_triangle_up: ( previous job: 7.54, degradation: 110.55%)
  • whonix-gateway-17_exec-data-simplex: 73.36 :small_red_triangle_up: ( previous job: 48.76, degradation: 150.44%)
  • whonix-gateway-17_exec-data-duplex: 75.39 :small_red_triangle_up: ( previous job: 48.55, degradation: 155.26%)
  • whonix-gateway-17_exec-data-duplex-root: 96.06 :small_red_triangle_up: ( previous job: 70.13, degradation: 136.98%)
  • whonix-gateway-17_socket-data-duplex: 153.60 :small_red_triangle_up: ( previous job: 82.74, degradation: 185.65%)
  • whonix-workstation-17_exec-data-simplex: 69.72 :small_red_triangle_up: ( previous job: 47.01, degradation: 148.29%)
  • whonix-workstation-17_exec-data-duplex: 73.50 :small_red_triangle_up: ( previous job: 49.48, degradation: 148.56%)
  • whonix-workstation-17_exec-data-duplex-root: 92.05 :small_red_triangle_up: ( previous job: 79.93, degradation: 115.17%)
  • whonix-workstation-17_socket-data-duplex: 163.00 :small_red_triangle_up: ( previous job: 81.71, degradation: 199.48%)
  • dom0_root_seq1m_q8t1_read 3:read_bandwidth_kb: 349758.00 :small_red_triangle_up: ( previous job: 486352.00, degradation: 71.91%)
  • dom0_root_seq1m_q8t1_write 3:write_bandwidth_kb: 128196.00 :small_red_triangle_up: ( previous job: 276742.00, degradation: 46.32%)
  • dom0_root_seq1m_q1t1_read 3:read_bandwidth_kb: 134909.00 :small_red_triangle_up: ( previous job: 423495.00, degradation: 31.86%)
  • dom0_root_seq1m_q1t1_write 3:write_bandwidth_kb: 27247.00 :small_red_triangle_up: ( previous job: 185030.00, degradation: 14.73%)
  • dom0_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 19437.00 :small_red_triangle_up: ( previous job: 100699.00, degradation: 19.30%)
  • dom0_varlibqubes_seq1m_q8t1_read 3:read_bandwidth_kb: 413476.00 :small_red_triangle_up: ( previous job: 475329.00, degradation: 86.99%)
  • dom0_varlibqubes_rnd4k_q32t1_write 3:write_bandwidth_kb: 7381.00 :small_red_triangle_up: ( previous job: 8767.00, degradation: 84.19%)
  • fedora-41-xfce_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 1987.00 :small_red_triangle_up: ( previous job: 3785.00, degradation: 52.50%)
  • fedora-41-xfce_private_rnd4k_q32t1_write 3:write_bandwidth_kb: 3287.00 :small_red_triangle_up: ( previous job: 3885.00, degradation: 84.61%)
  • fedora-41-xfce_private_rnd4k_q1t1_write 3:write_bandwidth_kb: 1189.00 :small_red_triangle_up: ( previous job: 1613.00, degradation: 73.71%)
  • fedora-41-xfce_volatile_seq1m_q1t1_write 3:write_bandwidth_kb: 59045.00 :small_red_triangle_up: ( previous job: 78093.00, degradation: 75.61%)
  • fedora-41-xfce_volatile_rnd4k_q32t1_write 3:write_bandwidth_kb: 2428.00 :small_red_triangle_up: ( previous job: 3959.00, degradation: 61.33%)

Remaining performance tests:

42 tests
  • debian-12-xfce_exec-root: 29.12 :small_red_triangle_up: ( previous job: 27.97, degradation: 104.11%)
  • debian-12-xfce_socket: 8.80 :small_red_triangle_up: ( previous job: 8.33, degradation: 105.68%)
  • debian-12-xfce_socket-root: 8.40 :small_red_triangle_up: ( previous job: 8.20, degradation: 102.42%)
  • fedora-41-xfce_exec: 9.23 :small_red_triangle_up: ( previous job: 9.13, degradation: 101.04%)
  • fedora-41-xfce_exec-root: 60.04 🟢 ( previous job: 61.17, improvement: 98.15%)
  • fedora-41-xfce_socket: 8.99 :small_red_triangle_up: ( previous job: 8.66, degradation: 103.85%)
  • fedora-41-xfce_socket-root: 8.93 :small_red_triangle_up: ( previous job: 8.61, degradation: 103.77%)
  • whonix-gateway-17_exec: 6.80 🟢 ( previous job: 7.87, improvement: 86.44%)
  • whonix-gateway-17_exec-root: 40.48 :small_red_triangle_up: ( previous job: 38.36, degradation: 105.53%)
  • whonix-gateway-17_socket-root: 7.76 🟢 ( previous job: 8.27, improvement: 93.81%)
  • whonix-workstation-17_exec: 8.13 🟢 ( previous job: 8.23, improvement: 98.78%)
  • whonix-workstation-17_exec-root: 52.84 :small_red_triangle_up: ( previous job: 52.56, degradation: 100.52%)
  • whonix-workstation-17_socket: 8.93 :small_red_triangle_up: ( previous job: 8.21, degradation: 108.76%)
  • whonix-workstation-17_socket-root: 8.35 :small_red_triangle_up: ( previous job: 8.20, degradation: 101.82%)
  • dom0_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 4404.00 :green_circle: ( previous job: 3277.00, improvement: 134.39%)
  • dom0_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 12108.00 :green_circle: ( previous job: 10163.00, improvement: 119.14%)
  • dom0_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 3441.00 :green_circle: ( previous job: 282.00, improvement: 1220.21%)
  • dom0_varlibqubes_seq1m_q8t1_write 3:write_bandwidth_kb: 226670.00 :green_circle: ( previous job: 95209.00, improvement: 238.08%)
  • dom0_varlibqubes_seq1m_q1t1_read 3:read_bandwidth_kb: 440023.00 :green_circle: ( previous job: 433474.00, improvement: 101.51%)
  • dom0_varlibqubes_seq1m_q1t1_write 3:write_bandwidth_kb: 169202.00 :green_circle: ( previous job: 164133.00, improvement: 103.09%)
  • dom0_varlibqubes_rnd4k_q32t1_read 3:read_bandwidth_kb: 104757.00 :green_circle: ( previous job: 99808.00, improvement: 104.96%)
  • dom0_varlibqubes_rnd4k_q1t1_read 3:read_bandwidth_kb: 8505.00 :green_circle: ( previous job: 7053.00, improvement: 120.59%)
  • dom0_varlibqubes_rnd4k_q1t1_write 3:write_bandwidth_kb: 4254.00 :green_circle: ( previous job: 3868.00, improvement: 109.98%)
  • fedora-41-xfce_root_seq1m_q8t1_read 3:read_bandwidth_kb: 432402.00 :green_circle: ( previous job: 396586.00, improvement: 109.03%)
  • fedora-41-xfce_root_seq1m_q8t1_write 3:write_bandwidth_kb: 216647.00 :green_circle: ( previous job: 99783.00, improvement: 217.12%)
  • fedora-41-xfce_root_seq1m_q1t1_read 3:read_bandwidth_kb: 309497.00 :small_red_triangle_up: ( previous job: 343795.00, degradation: 90.02%)
  • fedora-41-xfce_root_seq1m_q1t1_write 3:write_bandwidth_kb: 114978.00 :green_circle: ( previous job: 44770.00, improvement: 256.82%)
  • fedora-41-xfce_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 80480.00 :small_red_triangle_up: ( previous job: 86742.00, degradation: 92.78%)
  • fedora-41-xfce_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 9234.00 :green_circle: ( previous job: 8623.00, improvement: 107.09%)
  • fedora-41-xfce_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 1499.00 :green_circle: ( previous job: 1126.00, improvement: 133.13%)
  • fedora-41-xfce_private_seq1m_q8t1_read 3:read_bandwidth_kb: 390385.00 :small_red_triangle_up: ( previous job: 401907.00, degradation: 97.13%)
  • fedora-41-xfce_private_seq1m_q8t1_write 3:write_bandwidth_kb: 303231.00 :green_circle: ( previous job: 116848.00, improvement: 259.51%)
  • fedora-41-xfce_private_seq1m_q1t1_read 3:read_bandwidth_kb: 349292.00 :small_red_triangle_up: ( previous job: 357875.00, degradation: 97.60%)
  • fedora-41-xfce_private_seq1m_q1t1_write 3:write_bandwidth_kb: 95284.00 :green_circle: ( previous job: 41375.00, improvement: 230.29%)
  • fedora-41-xfce_private_rnd4k_q32t1_read 3:read_bandwidth_kb: 84630.00 :small_red_triangle_up: ( previous job: 87999.00, degradation: 96.17%)
  • fedora-41-xfce_private_rnd4k_q1t1_read 3:read_bandwidth_kb: 7991.00 :small_red_triangle_up: ( previous job: 8744.00, degradation: 91.39%)
  • fedora-41-xfce_volatile_seq1m_q8t1_read 3:read_bandwidth_kb: 384657.00 :small_red_triangle_up: ( previous job: 392725.00, degradation: 97.95%)
  • fedora-41-xfce_volatile_seq1m_q8t1_write 3:write_bandwidth_kb: 205371.00 :green_circle: ( previous job: 139933.00, improvement: 146.76%)
  • fedora-41-xfce_volatile_seq1m_q1t1_read 3:read_bandwidth_kb: 347440.00 :green_circle: ( previous job: 294875.00, improvement: 117.83%)
  • fedora-41-xfce_volatile_rnd4k_q32t1_read 3:read_bandwidth_kb: 82261.00 :green_circle: ( previous job: 71108.00, improvement: 115.68%)
  • fedora-41-xfce_volatile_rnd4k_q1t1_read 3:read_bandwidth_kb: 8356.00 :small_red_triangle_up: ( previous job: 8408.00, degradation: 99.38%)
  • fedora-41-xfce_volatile_rnd4k_q1t1_write 3:write_bandwidth_kb: 2455.00 :small_red_triangle_up: ( previous job: 2693.00, degradation: 91.16%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants