[Not yet finished] Fix wattmeter probe #946
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Qucs/qucsator#47 .
There where two main issues:
this was easy, just use the correct formula for the power
this required changing the nodes order for the component in the netlist: the probes are a bit of a hack and currently require the voltage sensing to be on the first two nodes, while the wattmeter had the current sensing there.
I also couldn't resist changing a little the probe values output handling to make it feel a little less "hackish" (IMHO).
This goes together with the
qucs-test
update at Qucs/qucs-test#35 .