Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qucs#956 command line enhancement #984

Closed
wants to merge 2 commits into from

Conversation

oxmon-2500
Copy link
Contributor

@oxmon-2500 oxmon-2500 commented Mar 4, 2020

Ticket #956
Command line enhancement: It is now possible to specify a project and schematic files to open by command line.
Usage: /home/gAz_/local/qucs/bin/qucs [-h|--help] [-v|--version]
qucs -n -i FILENAME -o FILENAME
qucs -p -i FILENAME -o FILENAME.[pdf|png|svg|eps]
qucs [ projectPath] [ filePath1 [ filePath2 ... ] ] ]

-h, --help display this help and exit
-v, --version display version information and exit
...

Examples:
qucs ../qucs-test/testsuite/AC_bandpass_prj/ bandpass.sch opa227.sch
qucs ~/proj/qucs-test/testsuite/DC_AC_gain_prj "*.sch"

@guitorri
Copy link
Member

guitorri commented Mar 7, 2020

What is the issue you are addressing?
Please describe what your are trying to achieve in the commit message.

I would rather not modify the QucsApp() constructor.
If we have to pass all possible initial settings to the constructor it will be a mess.
Can't you add another method to pass the lists and set the things you want?

@oxmon-2500 oxmon-2500 force-pushed the qucs_956_cmdline_clean branch from a222e76 to 0c26661 Compare March 7, 2020 16:44
@oxmon-2500
Copy link
Contributor Author

@guitorri Thank you for the rebase advice. It was working perfect now.
As you have the best overview over the development, and knowledge what issues are of the most importance, so feel free to point out what next issue can be approached by me. To my person: I'm retired software developer (last years mostly java) and the electronics knowledge is rather from my interests and not from my profession. Nevertheless it would be a pleasure to add some contribution to this great project.
Cheers from Baden bei Wien/Austria
Szymon

@oxmon-2500 oxmon-2500 changed the title qucs_956_cmdline_clean commandLine qucs#956 command line enhancement Mar 10, 2020
@guitorri
Copy link
Member

Hi Szymon,

I meant that the description of the changes should be recorded on the commit message itself, not only on the GitHub pull request description. Also, preferably mention the issue number on the body of the message not on the title. If one day we change away from GitHub these numbers will be meaningless.
See also: https://github.com/Qucs/qucs/wiki/Contribution#rules-about-commits

Try git commit --amend and edit the commit message.

Your interest on the project is appreciated.
I would suggest you to take a look on the milestones for the next release and try to address issues from there. See https://github.com/Qucs/qucs/milestone/4
This one has high priority: #830

Cheers,
Guilherme

qucs issue Qucs#956
Additionaly to existing options the following arguments are allowed:
qucs [ projectPath] [ filePath1  [ filePath2 ... ] ] ]
@oxmon-2500 oxmon-2500 force-pushed the qucs_956_cmdline_clean branch from e5bd2f5 to 50c7740 Compare March 11, 2020 11:17
@felix-salfelder felix-salfelder deleted the branch Qucs:develop July 2, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants