Skip to content

app 쪽 커밋 메시지 영어로 수정 #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
apaals2 merged 3 commits into from
Jul 27, 2025
Merged

app 쪽 커밋 메시지 영어로 수정 #28

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5f22d10
style: app 쪽 커밋 메시지 영어로 수정
ChoiSeungWoo98 Jul 24, 2025
a5267aa
feat: 테스트 가능하도록 수정
ChoiSeungWoo98 Jul 24, 2025
0fcc1a0
feat: Skip deployment jobs on manual trigger
ChoiSeungWoo98 Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/workflows/build_release_and_notify.yml
View file
Open in desktop
Copy link
Contributor

@apaals2 apaals2 Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if: github.event_name == 'release' 이 이부분 추가하고 안하고의 차이가 있나요? 확실하게 release 상태일 때 파이프라인 돌게하려고 한건가요?

Copy link
Contributor Author

@ChoiSeungWoo98 ChoiSeungWoo98 Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네 맞습니다.
빌드를 수동으로 돌리는 경우 실제 배포를 진행하지 않기 위해 release 배포인 경우에만 배포가 돌수 있도록 수정하였습니다.

Original file line number Diff line number Diff line change
@@ -1,16 +1,17 @@
# .github/workflows/build_release_and_notify.yml

name: Build and Deploy Executables

on:
release:
types: [published] # Release가 'published' 상태가 될 때 트리거
workflow_dispatch:

jobs:
# ==================================
# 파이프라인 시작 알림
# ==================================
start:
if: github.event_name == 'release'
runs-on: ubuntu-latest
steps:
- name: Send Pipeline Start Notification
Expand All @@ -28,7 +29,6 @@ jobs:
# 실행 파일 빌드
# ==================================
build:
needs: start
strategy:
matrix:
os: [macos-latest, windows-latest]
Expand Down Expand Up @@ -90,6 +90,7 @@ jobs:
# ==================================
deploy:
needs: build
if: github.event_name == 'release'
runs-on: ubuntu-latest

steps:
Expand Down Expand Up @@ -119,7 +120,7 @@ jobs:
if git diff-index --quiet HEAD; then
echo "No changes to commit to QGenie APP repository."
else
git commit -m "feat: API 실행 파일 업데이트 (${{ github.ref_name }})"
git commit -m "feat: Update API executable (${{ github.ref_name }})"
git push
fi

Expand All @@ -129,7 +130,7 @@ jobs:
finish:
needs: deploy
runs-on: ubuntu-latest
if: always()
if: always() && github.event_name == 'release'

steps:
- name: Send Success Notification
Expand Down