Skip to content

Change ruby support (and testing) to remove < 3.0, and add 3.2 and 3.3 #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Change ruby support (and testing) to remove < 3.0, and add 3.2 and 3.3 #347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1bba49
Change ruby support (and testing) to remove < 3.0, and add 3.2 and 3.3
ukd1 Mar 21, 2024
90b4b0b
Update to newer action for checkout
ukd1 Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby_version: ['2.6', '2.7', '3.0', '3.1']
ruby_version: ['3.0', '3.1', '3.2', '3.3']
services:
postgres:
image: postgres
Expand All @@ -50,7 +50,7 @@ jobs:
ports:
- 5432:5432
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Install postgresql-client
run: |
sudo apt-get update
Expand All @@ -68,4 +68,4 @@ jobs:
DATABASE_URL: postgres://postgres:postgres@localhost/postgres
QC_BENCHMARK: true
QC_BENCHMARK_MAX_TIME_DEQUEUE: 60
QC_BENCHMARK_MAX_TIME_ENQUEUE: 10
QC_BENCHMARK_MAX_TIME_ENQUEUE: 10
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ A major benefit is the ability to enqueue inside transactions, ensuring things a

### Requirements
For this version, the requirements are as follows:
* Ruby 2.6, 2.7, 3.0, 3.1 - i.e. currently supported Ruby versions
* Ruby 3.0, 3.1, 3.2, 3.3 - i.e. currently supported non-EOL Ruby versions
* Postgres ~> 9.6
* Rubygem: pg ~> 1.1

Expand Down Expand Up @@ -212,7 +212,7 @@ bundle exec rake db:migrate
```

#### Database connection
Starting with with queue_classic 3.1, Rails is automatically detected and its connection is used. If you don't want to use the automatic database connection, set this environment variable to false: `export QC_RAILS_DATABASE=false`.
Starting with with queue_classic 3.1, Rails is automatically detected and its connection is used. If you don't want to use the automatic database connection, set this environment variable to false: `export QC_RAILS_DATABASE=false`.

> **Note:** If you do not share the connection, you cannot enqueue in the same transaction as whatever you're doing in Rails.

Expand Down