-
Notifications
You must be signed in to change notification settings - Fork 18
Support Rails 7.1 and 7.2 #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Rails 7.1 and 7.2 #59
Conversation
|
/reviewme @grodowski @magni- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure Travis builds aren't running anymore, so we should probably replace that config with either a CircleCI config or a GH Actions workflow.
.travis.yml
Outdated
| - 3.0.7 | ||
| - 2.7.8 | ||
| - 2.6.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are all EOL so I think it's fine to remove them from the test matrix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@magni- the "rule" for the main QC repo is just to support what's current (ish) ruby wise - e.g. QueueClassic/queue_classic#347 - seems kinda sane for this project too?
Also GH actions would be ideal/great for here, as the main project uses that |
|
@sebaherrera07 ya, I can take a look for sure - will be today or tomorrow! |
Uh oh!
There was an error while loading. Please reload this page.