Skip to content

Conversation

@sebaherrera07
Copy link

@sebaherrera07 sebaherrera07 commented May 14, 2024

  • Also replaced unused Travis CI for GitHub Actions

@sebaherrera07
Copy link
Author

/reviewme @grodowski @magni-

Copy link
Contributor

@magni- magni- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure Travis builds aren't running anymore, so we should probably replace that config with either a CircleCI config or a GH Actions workflow.

.travis.yml Outdated
Comment on lines 11 to 13
- 3.0.7
- 2.7.8
- 2.6.10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all EOL so I think it's fine to remove them from the test matrix?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@magni- the "rule" for the main QC repo is just to support what's current (ish) ruby wise - e.g. QueueClassic/queue_classic#347 - seems kinda sane for this project too?

@ukd1
Copy link
Contributor

ukd1 commented May 18, 2024

I'm pretty sure Travis builds aren't running anymore, so we should probably replace that config with either a CircleCI config or a GH Actions workflow.

Also GH actions would be ideal/great for here, as the main project uses that

@sebaherrera07 sebaherrera07 changed the title Support Rails 7.1 Support Rails 7.1 and 7.2 Oct 7, 2024
@sebaherrera07
Copy link
Author

Also GH actions would be ideal/great for here, as the main project uses that

Haven't seen this until today 😅 . Just added a GitHub action, but not sure if it won't run until it gets merged because I'm not admin maybe?

@ukd1 can you review again and eventually merge it if you think is fine?

@ukd1
Copy link
Contributor

ukd1 commented Oct 7, 2024

@sebaherrera07 ya, I can take a look for sure - will be today or tomorrow!

@ukd1 ukd1 changed the base branch from master to rails-7.1-and-gh-actions October 7, 2024 21:22
@ukd1 ukd1 merged commit 4e56d83 into QueueClassic:rails-7.1-and-gh-actions Oct 7, 2024
@ukd1 ukd1 mentioned this pull request Oct 7, 2024
@sebaherrera07 sebaherrera07 deleted the support_rails_71 branch October 18, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants