Add requireFail. Like fail(), but it also always throws an error #1163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noamfreeman
reviewed
Nov 27, 2024
| /// | ||
| /// - Parameter message: A custom message to use in place of the default one. | ||
| /// - Parameter customError: A custom error to throw in place of a ``RequireError``. | ||
| public func requireFail(_ message: String? = nil, customError: Error? = nil, fileID: String = #fileID, filePath: FileString = #filePath, line: UInt = #line, column: UInt = #column) throws { |
There was a problem hiding this comment.
is it reasonable to return Never from this function?
otherwise the usage is a bit weird, since the caller needs to somehow return or fatal error after it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1161
The PR should summarize what was changed and why. Here are some questions to
help you if you're not sure:
Checklist - While not every PR needs it, new features should consider this list: