Rename the failable map overload to compactMap #1180
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yes, I just submitted the PR adding this new matcher. Then I thought on it some more and decided I didn't like the slightly different behavior between 2 different versions of map.
Instead, I renamed the map with optional transform to
compactMap
(which you can tell from the documentation that this was the original name before I made a decision to rename it to justmap
), and added another overload ofmap
that takes a closure returning an optional that behaves exactly like how the map without optional behaves.I also redid the tests to be sure to check all of this.
Checklist - While not every PR needs it, new features should consider this list: