Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of unsupported tvOS devices #287

Merged
merged 2 commits into from
Apr 24, 2016

Conversation

phatblat
Copy link
Member

Nimble cannot currently be used on tvOS devices since bitcode is required but the XCTest framework does not contain bitcode. By changing the SDKROOT to appletvsimulator on the Nimble-tvOS target, this has no effect on simulator builds, but provides an immediate and much more informative error on device builds instead of linker errors.

Before

screen shot 2016-04-23 at 5 49 42 pm

After

screen shot 2016-04-23 at 5 55 36 pm

Carthage

Carthage currently cannot build Nimble since it attempts to build for both the simulator and device (#213). I've proposed a fix for this in Carthage/Carthage#1268 which keys off of the ENABLE_BITCODE setting being NO to skip building for the device since bitcode is required to build for tvOS devices. This setting has no effect on simulator builds where bitcode is not used.

Gives immediate error instead of running build and failing with linker error complaining about XCTest not containing bitcode when attempting a device build
@ashfurrow
Copy link
Member

Cool!

@c0diq
Copy link

c0diq commented Jun 16, 2016

Not sure why but I can't bring Nimble with Carthage 0.16.2. Getting

=== CLEAN TARGET Nimble-tvOS OF PROJECT Nimble WITH CONFIGURATION Release ===

Check dependencies
target 'Nimble-tvOS' has bitcode disabled (ENABLE_BITCODE = NO), but it is required for the 'appletvos' platform

** CLEAN FAILED **

@phatblat
Copy link
Member Author

@c0diq There hasn't been a Carthage release since Carthage/Carthage#1280 was merged to address this.

Megal pushed a commit to Megal/Nimble that referenced this pull request Jul 31, 2019
Better handling of unsupported tvOS devices
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants