Better handling of unsupported tvOS devices #287
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nimble cannot currently be used on tvOS devices since bitcode is required but the XCTest framework does not contain bitcode. By changing the
SDKROOT
toappletvsimulator
on the Nimble-tvOS target, this has no effect on simulator builds, but provides an immediate and much more informative error on device builds instead of linker errors.Before
After
Carthage
Carthage currently cannot build Nimble since it attempts to build for both the simulator and device (#213). I've proposed a fix for this in Carthage/Carthage#1268 which keys off of the
ENABLE_BITCODE
setting beingNO
to skip building for the device since bitcode is required to build for tvOS devices. This setting has no effect on simulator builds where bitcode is not used.