Make non variadic contains matchers public #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows matching for an collection to contain a slice of itself and bypasses an open issue in Swift 2 https://bugs.swift.org/browse/SR-128
|
Fab! |
Megal
pushed a commit
to Megal/Nimble
that referenced
this pull request
Jul 31, 2019
Make non variadic contains matchers public
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we can match for
expect([1, 2, 3]).to(contain(1, 2))but we can not matchexpect([1, 2, 3]).to(contain([1, 2])). The matching functions are already present, and I don't see the reason for them to not be public.This makes the following scenario easier to write:
There's also a swift bug filed that would support this use case out of the box, but it's still open: https://bugs.swift.org/browse/SR-128