Support both Swift 3.x and Swift 4 #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please review @Quick/core 🙏 |
ashfurrow
approved these changes
Aug 28, 2017
Sources/Nimble/DSL+Wait.swift
Outdated
| @@ -11,6 +11,8 @@ private enum ErrorResult { | |||
| /// bridges to Objective-C via the @objc keyword. This class encapsulates callback-style | |||
| /// asynchronous waiting logic so that it may be called from Objective-C and Swift. | |||
| internal class NMBWait: NSObject { | |||
| #if (os(macOS) || os(iOS) || os(tvOS) || os(watchOS)) && !SWIFT_PACKAGE | |||
There was a problem hiding this comment.
Seems like the kind of line we should document?
…watchOS)) && !SWIFT_PACKAGE` check [ci skip]
|
Thanks for your review and the feedback @ashfurrow! I added a comment in 2f28fd3. Feel free to update it if it is insufficient or poor english 🙏 Merging. |
Megal
pushed a commit
to Megal/Nimble
that referenced
this pull request
Jul 31, 2019
Support both Swift 3.x and Swift 4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to Quick/Quick#735.