[7.x] Update CwlPreconditionTesting and utilize _swift_reportFatalErrorsToDebugger #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikesyo
force-pushed
the
update-cwlpreconditiontesting
branch
from
8a80caa to
40b0175
Compare
sharplet
reviewed
Jun 20, 2018
| currentTestCase = testCase | ||
| } | ||
|
|
||
| @objc func testCaseDidFinish(_ testCase: XCTestCase) { | ||
| currentTestCase = nil | ||
|
|
||
| #if swift(>=3.2) | ||
| _swift_reportFatalErrorsToDebugger = true |
There was a problem hiding this comment.
Would it make sense to stash the previous value so we can restore it, rather than assuming true?
sharplet
approved these changes
Jun 25, 2018
1 task
Megal
pushed a commit
to Megal/Nimble
that referenced
this pull request
Jul 31, 2019
[7.x] Update CwlPreconditionTesting and utilize _swift_reportFatalErrorsToDebugger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #478. See #478 (comment) for the details.