Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swift 4.2 Support - Remove usage of obsolete RunLoop.Mode #553

Closed
wants to merge 1 commit into from
Closed

Swift 4.2 Support - Remove usage of obsolete RunLoop.Mode #553

wants to merge 1 commit into from

Conversation

jeffypooo
Copy link

Issue Overview

A build error is thrown when trying to use Nimble in a project using Swift 4.2 + Xcode 10 B2 due to renamed RunLoop.Mode constants.

Changes

  • Replaced usage of RunLoop.Mode.defaultRunLoopMode with .default in AwaitPromiseBuilder.

@ikesyo
Copy link
Member

ikesyo commented Jun 26, 2018

Closing this in favor of #549. Thanks for the PR though!

@ikesyo ikesyo closed this Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffypooo @ikesyo