Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "🐛Workaround to noescape bug in Xcode 10 beta 1" #560

Merged
merged 1 commit into from
Jul 5, 2018

Conversation

ikesyo
Copy link
Member

@ikesyo ikesyo commented Jul 4, 2018

Reverts #537

The underlying issue seems to be fixed in Xcode 10 beta 3. See #537 (comment) for the details.

@ikesyo ikesyo requested review from phatblat and a team July 4, 2018 16:34
Copy link
Contributor

@sharplet sharplet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't verified myself, but lgtm 👍

Copy link
Member

@wongzigii wongzigii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@ikesyo
Copy link
Member Author

ikesyo commented Jul 5, 2018

:shipit:

@ikesyo ikesyo merged commit 7f550dd into master Jul 5, 2018
@ikesyo ikesyo deleted the revert-537-noescape-workaround branch July 5, 2018 12:11
Megal pushed a commit to Megal/Nimble that referenced this pull request Jul 31, 2019
Revert "🐛Workaround to noescape bug in Xcode 10 beta 1"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants