[7.x] Refactor contain matcher using Predicate.simple
#573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharplet
approved these changes
Jul 13, 2018
| if let actual = try actualExpression.evaluate() { | ||
| return items.all { | ||
| let matches = items.all { |
There was a problem hiding this comment.
Not necessary in this PR, but wondering if we can rename this to allSatisfy and make it a compatibility shim for Swift < 4.2? https://github.com/apple/swift-evolution/blob/master/proposals/0207-containsOnly.md
| return items.all { item in | ||
| return Predicate.simple("contain <\(arrayAsString(items))>") { actualExpression in | ||
| guard let actual = try actualExpression.evaluate() else { return .fail } | ||
| let matches = items.all { item in | ||
| return item != nil && actual.contains(item!) |
There was a problem hiding this comment.
Thoughts on restructuring this to avoid the force-unwrap?
Replacing `Predicate.fromDeprecatedClosure`.
ikesyo
force-pushed
the
refactor-contain-matcher
branch
from
380f957 to
9bbe098
Compare
Megal
pushed a commit
to Megal/Nimble
that referenced
this pull request
Jul 31, 2019
[7.x] Refactor `contain` matcher using `Predicate.simple`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing
Predicate.fromDeprecatedClosure.