Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Replace AsyncMatcherWrapper with async function #590

Merged
merged 2 commits into from
Aug 14, 2018

Conversation

ikesyo
Copy link
Member

@ikesyo ikesyo commented Aug 6, 2018

The Predicate returned from async can be used as a Matcher for toEventually and toEventuallyNot.

@ikesyo ikesyo requested a review from a team August 6, 2018 16:04
@ikesyo
Copy link
Member Author

ikesyo commented Aug 6, 2018

Hmm Utils/Async.swift should be renamed to Await.swift.

Copy link
Member

@wongzigii wongzigii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make senses 👍

@ikesyo
Copy link
Member Author

ikesyo commented Aug 14, 2018

Thanks!

@ikesyo ikesyo merged commit 6dd9a01 into 7.x-branch Aug 14, 2018
@ikesyo ikesyo deleted the replace-AsyncMatcherWrapper-with-async branch August 14, 2018 14:30
Megal pushed a commit to Megal/Nimble that referenced this pull request Jul 31, 2019
…ith-async

[7.x] Replace `AsyncMatcherWrapper` with `async` function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants