Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workaround to SR-2290 #593

Merged
merged 1 commit into from
Aug 14, 2018
Merged

Remove workaround to SR-2290 #593

merged 1 commit into from
Aug 14, 2018

Conversation

norio-nomura
Copy link
Contributor

Since SR-2290 was fixed, so no workaround is needed.

Copy link
Member

@ikesyo ikesyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for master branch, which now requires Swift 4.1.

@ikesyo ikesyo merged commit f52c57e into Quick:master Aug 14, 2018
@norio-nomura norio-nomura deleted the remove-fixme-sr-2290 branch August 14, 2018 22:46
@norio-nomura
Copy link
Contributor Author

Thanks! 🙏

Megal pushed a commit to Megal/Nimble that referenced this pull request Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants