Add beEmpty matcher for SetAlgebra
#594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharplet
approved these changes
Aug 19, 2018
| @@ -34,16 +34,12 @@ final class BeEmptyTest: XCTestCase, XCTestCaseProvider { | |||
|
|
|||
| expect("").to(beEmpty()) | |||
| expect("foo").toNot(beEmpty()) | |||
|
|
|||
| expect([] as NSSortOptions).to(beEmpty()) | |||
There was a problem hiding this comment.
It feels slightly weird to rely on NSSortOptions here, how do you feel about creating a TestOptionSet type for testing purposes?
| @@ -73,5 +69,35 @@ final class BeEmptyTest: XCTestCase, XCTestCaseProvider { | |||
| failsWithErrorMessage("expected to be empty, got <foo>") { | |||
| expect("foo").to(beEmpty()) | |||
| } | |||
|
|
|||
| failsWithErrorMessage("expected to not be empty, got <NSSortOptions(rawValue: 0)>") { | |||
There was a problem hiding this comment.
Having our own option set type here would also decouple us from NSSortOptions's implementation of string conversion.
ikesyo
force-pushed
the
setalgebra-beempty
branch
from
dce0a49 to
9e2e6b4
Compare
|
@sharplet Addressed your feedback! |
sharplet
approved these changes
Aug 20, 2018
This was referenced Mar 7, 2019
Megal
pushed a commit
to Megal/Nimble
that referenced
this pull request
Jul 31, 2019
Add `beEmpty` matcher for `SetAlgebra`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially implements #496.