Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Replace expressionMatches with execute in to and toEventually #595

Merged
merged 1 commit into from
Aug 19, 2018

Conversation

ikesyo
Copy link
Member

@ikesyo ikesyo commented Aug 16, 2018

This is based on the works in #587 and #588.

@ikesyo ikesyo requested a review from a team August 16, 2018 14:08
@ikesyo ikesyo force-pushed the replace-expressionMatches branch from eb493cd to 50803bd Compare August 16, 2018 14:10
Copy link
Contributor

@sharplet sharplet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ikesyo
Copy link
Member Author

ikesyo commented Aug 19, 2018

Thanks!

@ikesyo ikesyo merged commit 0f168a7 into 7.x-branch Aug 19, 2018
@ikesyo ikesyo deleted the replace-expressionMatches branch August 19, 2018 23:50
Megal pushed a commit to Megal/Nimble that referenced this pull request Jul 31, 2019
[7.x] Replace `expressionMatches` with `execute` in `to` and `toEventually`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants