Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Xcode 10: Adjust Build Phases order #606

Merged
merged 1 commit into from
Sep 19, 2018
Merged

[7.x] Xcode 10: Adjust Build Phases order #606

merged 1 commit into from
Sep 19, 2018

Conversation

ikesyo
Copy link
Member

@ikesyo ikesyo commented Sep 19, 2018

Cherry-picks #605 into 7.x-branch.

`Headers` should be placed before `Sources` to match with the Xcode 10's project template.
@wongzigii
Copy link
Member

I just restarted the failed job and the test pass now.

@ikesyo
Copy link
Member Author

ikesyo commented Sep 19, 2018

Thanks @wongzigii

@ikesyo ikesyo merged commit 4a69382 into 7.x-branch Sep 19, 2018
@ikesyo ikesyo deleted the 7.x-pr605 branch September 19, 2018 16:17
Megal pushed a commit to Megal/Nimble that referenced this pull request Jul 31, 2019
[7.x] Xcode 10: Adjust Build Phases order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants