Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Package.swift #607

Merged
merged 3 commits into from
Sep 21, 2018
Merged

Update Package.swift #607

merged 3 commits into from
Sep 21, 2018

Conversation

heyzooi
Copy link
Contributor

@heyzooi heyzooi commented Sep 19, 2018

Updating Package.swift to support Swift 4.2

Updating Package.swift to support Swift 4.2
@ikesyo
Copy link
Member

ikesyo commented Sep 20, 2018

Thanks for the PR, but we (I) still want to keep Swift 4.1 compatibility.

Package@swift-4.2.swift Show resolved Hide resolved
Package@swift-4.2.swift Show resolved Hide resolved
Copy link
Member

@ikesyo ikesyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ikesyo ikesyo merged commit a145269 into Quick:master Sep 21, 2018
@heyzooi heyzooi deleted the patch-1 branch September 21, 2018 17:34
Megal pushed a commit to Megal/Nimble that referenced this pull request Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants