Reduce deprecated Matcher type usages in some matchers #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should I close the other one? |
|
@freak4pc There should be still some works to be done, so let's keep it open! |
|
Alright, sounds good. I'll wait for this to be merged, rebase, and do more work on that one. |
This was referenced Jun 5, 2019
Megal
pushed a commit
to Megal/Nimble
that referenced
this pull request
Jul 31, 2019
…e-usages Reduce deprecated Matcher type usages in some matchers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #661
/cc @freak4pc