Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Fix hanging toEventually when build with swift package manager (SPM) #716

Merged
merged 1 commit into from
Dec 15, 2019

Conversation

ikesyo
Copy link
Member

@ikesyo ikesyo commented Dec 15, 2019

Cherry-picks #711 into 8.x-branch.

Swift package manager uses -dead_strip as a linker flag
which falsefully strips away a method that is actually not
dead code (https://bugs.swift.org/browse/SR-11564).

Making AwaitPromise final fixes the problem for now
and shouldn’t have a negative effect.

Fixes #708
@ikesyo ikesyo merged commit 12d1e15 into 8.x-branch Dec 15, 2019
@ikesyo ikesyo deleted the 8.x-fix-spm-build branch December 15, 2019 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants