Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disambiguate postNotifications overloads #794

Merged
merged 1 commit into from
Jun 9, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Sources/Nimble/Matchers/PostNotification.swift
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ public func postNotifications(
@available(*, deprecated, renamed: "postNotifications(_:from:)")
public func postNotifications(
_ predicate: Predicate<[Notification]>,
fromNotificationCenter center: NotificationCenter = .default
fromNotificationCenter center: NotificationCenter
) -> Predicate<Any> {
postNotifications(predicate, from: center)
}
Expand Down Expand Up @@ -140,7 +140,7 @@ public func postNotifications<T>(
@available(*, deprecated, renamed: "postNotifications(_:from:)")
public func postNotifications<T>(
_ notificationsMatcher: T,
fromNotificationCenter center: NotificationCenter = .default
fromNotificationCenter center: NotificationCenter
) -> Predicate<Any> where T: Matcher, T.ValueType == [Notification] {
return postNotifications(notificationsMatcher, from: center)
}
Expand Down
2 changes: 1 addition & 1 deletion Tests/NimbleTests/Matchers/PostNotificationTest.swift
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ final class PostNotificationTest: XCTestCase {
expect {
// no notifications here!
return nil
}.to(postNotifications(beEmpty(), from: notificationCenter))
}.to(postNotifications(beEmpty()))
}

func testPassesWhenExpectedNotificationIsPosted() {
Expand Down