Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply Xcode 12 recommended settings #835

Merged
merged 2 commits into from
Oct 16, 2020
Merged

Apply Xcode 12 recommended settings #835

merged 2 commits into from
Oct 16, 2020

Conversation

arangato
Copy link
Contributor

@arangato arangato commented Oct 8, 2020

Xcode 12 insists on setting CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER flag. Otherwise it shows warning in issue navigator.

@ikesyo ikesyo changed the title Apply Xcode12 recommended settings Apply Xcode 12 recommended settings Oct 12, 2020
@ikesyo ikesyo self-requested a review October 12, 2020 17:30
ikesyo
ikesyo approved these changes Oct 16, 2020
View reviewed changes
Copy link
Member

@ikesyo ikesyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, LGTM 👍

@ikesyo ikesyo merged commit 3258c23 into Quick:master Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikesyo ikesyo ikesyo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arangato @ikesyo