Use target dependency condition instead of build machine info #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kateinoigakukun
changed the title
ikesyo
reviewed
Apr 24, 2021
- CwlPreconditionTesting is used on macOS and iOS - CwlPosixPreconditionTesting is used on tvOS Co-authored-by: IKEDA Sho <suicaicoca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since swift-tools-version 5.3, SwiftPM allows us to declare conditional target dependencies in Package.swift. This is an important part when cross-building a package.
For example, when building a binary for Linux on macOS (currently it's impossible), Package.swift is evaluated as
os(macOS) == true, but produced binary will run on Linux.So, the platform we build on does not always match the platform a produced binary will run on.
The
condition: .when(...)will be resolved based on the target platform a produced binary will run on.Checklist - While not every PR needs it, new features should consider this list: