[1.x] Set APPLICATION_EXTENSION_API_ONLY to YES
#791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 danger |
|
Ping @Quick/core |
sharplet
reviewed
Jun 9, 2018
| @@ -85,6 +85,7 @@ extension World { | |||
| } | |||
| #endif | |||
|
|
|||
| @nonobjc | |||
There was a problem hiding this comment.
Is this necessary? Does World use @objcMembers?
There was a problem hiding this comment.
Yes it's needed. Otherwise those conflict with objc_it and so on.
There was a problem hiding this comment.
This is the compilation errors without the attributes:
ikesyo
force-pushed
the
APPLICATION_EXTENSION_API_ONLY
branch
from
1b241a3 to
9fd71b2
Compare
This enables us to use Swift internal classes from Objective-C side with importing the generated header.
|
I'll consider this as well: Quick/Nimble#540 |
…e a linker warning This silences the "linking against a dylib which is not safe for use in application extensions: /Applications/Xcode.app/path/to/libswiftXCTest.dylib" linker warning.
|
Thanks @sharplet! |
This was referenced Jun 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables us to use Swift internal classes from Objective-C side with importing the generated header.
Fixes #749. See also Quick/Nimble#525.