This repository was archived by the owner on Feb 18, 2025. It is now read-only.
Increase specificity for hybrid ui #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
genedwards
approved these changes
Oct 6, 2017
| "prebuild:dist": "rimraf dist/*", | ||
| "build:dist": "rollup -c && rollup -c --environment ESBUNDLE && rollup -c --environment PRODUCTION", | ||
| "build:dist": | ||
| "rollup -c && rollup -c --environment ESBUNDLE && rollup -c --environment PRODUCTION", |
| updatedStrings[0] = `${cssWrapperStart}${updatedStrings[0]}` | ||
| updatedStrings[updatedStrings.length - 1] = `${updatedStrings[ | ||
| updatedStrings.length - 1 | ||
| ]}${cssWrapperEnd}` |
There was a problem hiding this comment.
updatedStrings.push(`${updatedStrings.pop()}${cssWrapperEnd}`)
possibly looks nicer, but probably less performant, maybe also more convoluted, whaddayathink?
I wish we could do array[-1] like python
There was a problem hiding this comment.
Hmm. I’ll try. I was having a lot of issues working with that strings array. I’m not sure if it’s typescript or what.
| @@ -1,26 +1,43 @@ | |||
| // @flow | |||
| import type { Interpolation, Target } from '../types' | |||
There was a problem hiding this comment.
Yeah. I have a really hard time reading this code.
|
I was planning on leaving this in a branch for now. Unless we can identify a way to make it generic and submit it to styled components. |
|
that sounds fine, another thing we need to figure out for cleanup post release and rollout |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT PR TO STYLED-COMPONENTS
This branch currently has the code we are using to increase specificity of classes for the hybrid UI. It also includes the ability to push this to our private repo.